Repository navigation
Conversation
Closes python#15532 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The proxy forwards to a real `set`, so a `frozenset` operand yields a `frozenset` and non-set operands yield `NotImplemented`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It returns `type(other)(...)`, which need not be a set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15532
#16502 already did most of the heavy lifting work by giving
setandfrozensettheir own correct reflected operators, this PR only needs to add generic fallback methods of the missing operators toAbstractSetand specify all possible return types inSetProxy, depending on the other operand.The ignore comment for the
boltonsstub is needed because it returns the type ofotherthere, which can be a list.https://github.com/mahmoud/boltons/blob/4332b35a278d694f30c99881faa61cde695c7a96/boltons/setutils.py#L354-L356
AI disclosure: I use Claude Opus 5.5 to help solve this issue.