Repository navigation
Some PRs into resolute-qcom-devel skip the approval step before pre-merge #192
Description
We want every PR into resolute-qcom-devel to need approval before pre-merge runs, since Axiom capacity is limited. Right now some PRs wait for approval and others don't:
| PR | Opened | Pre-merge |
|---|---|---|
| #172 | Oct 16 | waited for approval |
| #173 | Oct 16 | ran right away |
| #185 | Oct 21 | waited for approval |
| #188 | Oct 21 | ran right away |
All four target resolute-qcom-devel, come from forks, and have authors with Read access; #173 and #188 are from the same author. GitHub marks all of them as first-time contributors, but #172's author already has a merged PR (#76), so that isn't the rule. Held and unheld PRs were opened on the same days, so it isn't a settings change, and the runs that didn't wait started the second they were created.
The hold is GitHub's fork PR approval in the repo's Actions settings, nothing in our workflows. The required Build check only blocks merging. PRs from branches inside this repo never go through that approval at all.
My guess is org membership, but I can't see that or the Actions setting. Someone with org admin needs to check.
Activity
mynameistechno commentedon Oct 22, 2026
Non org-members will require workflow approval to run on first and all subsequent PRs.
If you wanted to gate everyone, you could perhaps use the environment-approve functionality. Robbie and Loic are using this elsewhere to require approval before kicking off debusine related workflows I believe