fix: resolve cross-package test failures in monorepo#52
Open
stooit wants to merge 1 commit into
Open
Conversation
- api.ts: import renamed useDebounce hook and re-export as useSearchDebounce - Button: forward aria-label for icon-only buttons and warn when missing - date.ts: produce deterministic DD/MM/YYYY format (locale-independent)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 5 failing tests and the related type error across the monorepo. After these changes
bun run testreports 13 pass / 0 fail andnpx tsc --noEmithas no new errors (only pre-existingbun:testresolution noise in untouched test files remains).Bugs fixed
apps/web/src/lib/api.tsimporteduseThrottlefrom@e2e/utils, which no longer exists. Updated to import the actual exportuseDebounceand re-export it under the consumer-facing nameuseSearchDebouncethat the test expects.Buttonnow forwardsaria-labelto the underlying<button>so it has an accessible name, and emits aconsole.warnwhen an icon-only button is rendered without one.packages/utils/src/format/date.tsproduced a locale-dependent string. Now builds a deterministicDD/MM/YYYYvalue so the day is not confused with the month.Verification
bun run test→ 13 pass / 0 failnpx tsc --noEmit→ no new errors (pre-existingbun:testtest-file errors are unchanged and out of scope)Assumptions / scope
useSearchDebounceper the test;api.tswas reconciled to that.🤖 Generated autonomously