fix: repair cross-package bugs and test harness wiring#59
Open
stooit wants to merge 1 commit into
Open
Conversation
- api.ts: import renamed hook useDebounce (was stale useThrottle) - Button: propagate ariaLabel to aria-label for icon-only buttons - DataTable: use functional state updater to fix sort stale-closure bug - date.ts: use Intl formatToParts for correct en-AU day-first ordering - bunfig.toml: preload happy-dom setup so bare 'bun test' registers DOM globals - tsconfig.json: add bun-types so test files resolve 'bun:test'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and type errors across the monorepo.
bun testnow reports 13 pass / 0 fail andnpx tsc --noEmitis clean.Root causes & fixes
apps/web/src/lib/api.tsuseThrottle(hook renamed inpackages/utils)useDebouncepackages/ui/.../Button.tsxariaLabelprop never applied to the DOMariaLabeltoaria-labelpackages/ui/.../DataTable.tsxsortDirpackages/utils/.../date.tsen-AUordering (USM/D/YYYY)formatToPartsfor day-first orderingbunfig.tomlbun testfailed:document is not definedpreloadfor happy-dom setuptsconfig.jsonbun:testbun-typestotypesVerification
bun test→ 13 pass / 0 failnpx tsc --noEmit→ exit 0Scope
No test files modified; no dependencies added (
bun-types+ happy-dom already installed). Optional hardening flagged in review left out per the "fix only what tests require" constraint.🤖 Generated autonomously by QuantCode.