Conversation
Ported from SQLFluff 163858bee800fcaf18e9b98f99b22cdfa72026ac sqlfluff/sqlfluff#6999
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 150876fb61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ), | ||
| Matcher::regex( | ||
| "magic_single_line", | ||
| r"(-- MAGIC %)([^\n]{2,})( [^%]{1})([^\n]*)", |
There was a problem hiding this comment.
Databricks supports the %r language magic, but the {2,} requirement prevents inputs such as -- MAGIC %r 1+1 from becoming MagicSingleLine. With a trailing newline they instead match magic_start, which consumes that newline and leaves only one newline before -- COMMAND ----------, so the command delimiter matcher no longer recognizes the next cell boundary; at EOF the line falls through to a regular comment entirely. Allow the command portion to contain a single character.
Useful? React with 👍 / 👎.
Benchmark for ea928eeClick to view benchmark
|
1 participant
Summary
%run ./Notebook, alongside multiline magic cells.Ported from SQLFluff 163858bee800fcaf18e9b98f99b22cdfa72026ac
sqlfluff/sqlfluff#6999
sqlfluff/sqlfluff@163858b
Validation
cargo fmt --all -- --checkcargo buildcargo testbazel test //... --test_timeout=600,300,900,3600 --local_test_jobs=1 --lockfile_mode=off