Conversation
Ported from SQLFluff b8f99fd9d4acb2a9df139f183df7025fef4906aa sqlfluff/sqlfluff#7002
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3012324a41
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Sequence::new(vec![ | ||
| Ref::keyword("VARIADIC").to_matchable(), | ||
| Ref::new("ExpressionSegment").to_matchable(), | ||
| ]) |
There was a problem hiding this comment.
When a general variadic expression follows one or more fixed arguments, such as concat_ws(',', VARIADIC make_values()), this alternative cannot be reached because it is only a top-level FunctionContentsGrammar element; the existing delimited argument matcher stops when the reserved VARIADIC token cannot start an ExpressionSegment. The added multi-argument fixture passes only because VARIADIC ARRAY[...] is already consumed as a TypedArrayLiteralSegment. Add the variadic form to the delimited argument alternatives so PostgreSQL's valid fixed-arguments-plus-variadic-expression form parses.
Useful? React with 👍 / 👎.
Benchmark for 905d197Click to view benchmark
|
1 participant
Summary
Ported from SQLFluff b8f99fd9d4acb2a9df139f183df7025fef4906aa
sqlfluff/sqlfluff#7002
sqlfluff/sqlfluff@b8f99fd
Validation
cargo fmt --all -- --checkcargo buildcargo testbazel test //... --test_timeout=600,300,900,3600 --local_test_jobs=1 --lockfile_mode=off