Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35c9367e38
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| NodeMatcher::new(SyntaxKind::MapTypeSchema, |_| { | ||
| one_of(vec
When a valid comparable structural type is used as a key, such as MAP(ROW(x BIGINT), VARCHAR), both schema alternatives reject it because the key is restricted to PrimitiveTypeSegment. Trino permits comparable ROW and ARRAY types as map keys, so these valid declarations become unparsable; use a datatype grammar for the key and leave comparability validation to Trino.
Useful? React with 👍 / 👎.
Benchmark for 884ed3cClick to view benchmark
|
## Summary - Support round and angle bracket MAP schemas with primitive keys and nested values. - Port structural-type SQL and refresh Trino parse fixtures. Ported from SQLFluff d9a860d91a59f848f7f277d7d6fc4729319b7b93 sqlfluff/sqlfluff#7008 sqlfluff/sqlfluff@d9a860d
35c9367 to
f6b642c
Compare
1 participant
Summary
Ported from SQLFluff d9a860d91a59f848f7f277d7d6fc4729319b7b93
sqlfluff/sqlfluff#7008
sqlfluff/sqlfluff@d9a860d
Validation
cargo fmt --all -- --checkcargo buildcargo testbazel test //... --test_timeout=600,300,900,3600 --local_test_jobs=1 --lockfile_mode=off