http3: accept interfaces, not structs - #5239
Draft
marten-seemann wants to merge 1 commit into
Draft
marten-seemann wants to merge 1 commit into
marten-seemann wants to merge 1 commit into
Conversation
marten-seemann
commented
Jun 25, 2025
| // If Dial is nil, a UDPConn will be created at the first request | ||
| // and will be reused for subsequent connections to other servers. | ||
| Dial func(ctx context.Context, addr string, tlsCfg *tls.Config, cfg *quic.Config) (*quic.Conn, error) | ||
| Dial func(ctx context.Context, addr string, tlsCfg *tls.Config, cfg *quic.Config) (QUICConn, error) |
Member
Author
There was a problem hiding this comment.
This is super ugly. It's now not possible anymore to use quic.Dial: the user has to manually wrap the returned quic.Conn.
❌ 4 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One - rather ugly - option of resolving #5240.