Repository navigation
Fix generated Spark config placement in raydp-submit - #491
Open
my-vegetable-has-exploded wants to merge 1 commit into
Open
my-vegetable-has-exploded wants to merge 1 commit into
my-vegetable-has-exploded wants to merge 1 commit into
Conversation
Prepend generated configs before user arguments to prevent them from reaching application parsers. Preserve spaces in the Ray config path and cover argument boundaries and explicit config precedence with launcher tests. Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prepend generated Spark
--confoptions before user arguments inraydp-submit, preserving application argument boundaries. Quote the Ray config path and add launcher regression tests. Explicit user--confvalues now override generated defaults.Why is this change needed?
The launcher inserts generated configs before the last argument, assuming it is the application resource. With application arguments, the configs instead reach the application parser.
For example:
Before (simplified SparkSubmit arguments):
This causes
main.py: error: unrecognized arguments: --conf ....After:
Related Issue
None.
Type of Change
How was this tested?
Tests fail on the original launcher and pass with the fix. They exercise the real shell launcher without a cluster, covering Python/JAR entrypoints, zero/multiple application arguments, spaces and empty values,
--ray-conf, and explicit driver address precedence.Checklist
No CLI changes. The intentional precedence change for duplicate
--confvalues is noted above; no separate documentation update is needed.