Repository navigation
fix: retain executor owner handles across restarts - #492
Open
my-vegetable-has-exploded wants to merge 3 commits into
Open
my-vegetable-has-exploded wants to merge 3 commits into
my-vegetable-has-exploded wants to merge 3 commits into
Conversation
added 2 commits
October 16, 2026 09:30
Signed-off-by: epsilonwang <epsilonwang@didiglobal.com>
Signed-off-by: epsilonwang <epsilonwang@didiglobal.com>
2 of 11 tasks
Collaborator
|
@my-vegetable-has-exploded can you rebase from master? |
Contributor
Author
done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reuse the actor slot's original owner handle when an executor restarts, while assigning a new Spark executor ID. Keep rejecting restart requests for removed or unknown slots.
Why is this change needed?
The restart handler currently calls
Ray.getActorand replaces the stored owner handle with a named-lookup handle. This can make the original owner handle eligible for garbage collection while the executor is still needed. Reusing the existing handle preserves its lifetime and avoids an unnecessary lookup.Related Issue
None.
Type of Change
How was this tested?
With JDK 17 and the default Spark 4.0.0 / Scala 2.13 configuration:
cd core mvn clean package -DskipTests mvn -pl raydp-main -am verify -Dscalastyle.includeTestSourceDirectory=trueAll 12 core/shim modules build successfully. All 17 tests pass, including three new RPC regression tests for consecutive restarts, removed slots, and unknown slots. Java and Scala style checks pass. The new tests fail on the original handler because it requires a named lookup; they verify handle identity and recovery bookkeeping without starting Ray.
Checklist