Skip to content

fix: cap pyarrow below 26 for the TensorFlow extras and release workflow #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pang-wu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: cap pyarrow below 26 for the TensorFlow extras and release workflow #493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/pypi_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ jobs:
pip install "numpy<1.24" "click<8.3.0"
pip install "pydantic<2.0"
pip install torch --index-url https://download.pytorch.org/whl/cpu
pip install pyarrow "ray[train,default]==${{ env.RAY_VERSION }}" tqdm pytest tensorflow==2.16.1 tf_keras tabulate grpcio-tools wget
# pyarrow>=26 needs numpy>=2, which conflicts with the numpy<1.24 pin above.
pip install "pyarrow<26" "ray[train,default]==${{ env.RAY_VERSION }}" tqdm pytest tensorflow==2.16.1 tf_keras tabulate grpcio-tools wget
pip install "xgboost_ray[default]<=0.1.13"
pip install "xgboost<=2.0.3"
pip install torchmetrics
Expand Down
6 changes: 4 additions & 2 deletions python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,11 @@ def run(self):
'build_proto_modules': CustomBuildPackageProtos,
},
install_requires=install_requires,
# TensorFlow 2.15 requires numpy<2, while pyarrow>=26 fails to import without numpy>=2
# (and pyarrow does not declare numpy as a dependency), so cap pyarrow with TensorFlow.
extras_require={
"tensorflow": ["tensorflow>=2.15.1,<2.16"],
"tensorflow-gpu": ["tensorflow[and-cuda]>=2.15.1,<2.16"],
"tensorflow": ["tensorflow>=2.15.1,<2.16", "pyarrow<26"],
"tensorflow-gpu": ["tensorflow[and-cuda]>=2.15.1,<2.16", "pyarrow<26"],
},
setup_requires=["grpcio-tools"],
python_requires='>=3.10',
Expand Down
Loading