Skip to content

[Actions] New workflow runs in a PR should cancel any in-progress ones - #342

Merged
VeithMetro merged 4 commits into
masterfrom
development/actions-concurrency
Aug 21, 2026
Merged

VeithMetro merged 4 commits into
masterfrom
development/actions-concurrency

Conversation

@VeithMetro

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI lite review requested due to automatic review settings August 19, 2026 06:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds GitHub Actions concurrency settings to the platform build workflows so that newer runs on the same ref (notably PR updates) will cancel any older in-progress runs, reducing redundant CI usage.

Changes:

  • Added concurrency.group keyed by ${{ github.workflow }}-${{ github.ref }} to ensure cancellation is scoped per-workflow and per-ref.
  • Enabled cancel-in-progress for all refs except refs/heads/master, preserving non-canceling behavior for master branch runs.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/Build ThunderClientLibraries on Windows.yml Adds concurrency grouping and conditional cancel-in-progress for non-master refs.
.github/workflows/Build ThunderClientLibraries on MacOS.yml Adds concurrency grouping and conditional cancel-in-progress for non-master refs.
.github/workflows/Build ThunderClientLibraries on Linux.yml Adds concurrency grouping and conditional cancel-in-progress for non-master refs.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI review requested due to automatic review settings August 21, 2026 12:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (3)

.github/workflows/Build ThunderClientLibraries on Windows.yml:8

  • concurrency.group is based on github.ref, which means all runs on refs/heads/master share the same concurrency group. Even though cancel-in-progress is false on master, additional master runs will still be serialized (queued) rather than running concurrently. If the intent is to only cancel/limit runs for PRs, consider grouping PR runs by github.event.pull_request.number and using a unique fallback for non-PR events (e.g., github.run_id/github.sha) so master isn’t queued behind earlier runs.
concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}
  cancel-in-progress: ${{ github.ref != 'refs/heads/master' }}

.github/workflows/Build ThunderClientLibraries on Linux.yml:8

  • concurrency.group is based on github.ref, which means all runs on refs/heads/master share the same concurrency group. Even though cancel-in-progress is false on master, additional master runs will still be serialized (queued) rather than running concurrently. If the intent is to only cancel/limit runs for PRs, consider grouping PR runs by github.event.pull_request.number and using a unique fallback for non-PR events (e.g., github.run_id/github.sha) so master isn’t queued behind earlier runs.
concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}
  cancel-in-progress: ${{ github.ref != 'refs/heads/master' }}

.github/workflows/Build ThunderClientLibraries on MacOS.yml:8

  • concurrency.group is based on github.ref, which means all runs on refs/heads/master share the same concurrency group. Even though cancel-in-progress is false on master, additional master runs will still be serialized (queued) rather than running concurrently. If the intent is to only cancel/limit runs for PRs, consider grouping PR runs by github.event.pull_request.number and using a unique fallback for non-PR events (e.g., github.run_id/github.sha) so master isn’t queued behind earlier runs.
concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}
  cancel-in-progress: ${{ github.ref != 'refs/heads/master' }}

@VeithMetro
VeithMetro merged commit 9ca946c into master Aug 21, 2026
57 checks passed
@VeithMetro
VeithMetro deleted the development/actions-concurrency branch August 21, 2026 13:21
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants