RDKEMW-2864: Changes to fix Netflix Interface coding guideline errors

[jithajamesp]

Reason for change: Netflix Interface header not following coding guidelines
Test Procedure: Mentioned in ticket
Risks: Medium
Signed off by: Jitha James jitha_james@comcast.com

[Copilot]

🟡 Changes recommended

GetESN currently risks buffer overflow (length truncation + implementation that ignores max_length) and should be made safe before merging.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the Netflix security interface usage to follow the coding guideline style of returning Core::hresult and using output parameters, and aligns the unit test accordingly.

Changes:

• Replace value-returning getters (ESN(), EncryptionKey(), etc.) with Get* methods that return Core::hresult and fill out-parameters.
• Update NetflixSecurityTests to call the new Get* methods and validate success via return codes.

File summaries

File	Description
Source/cryptography/NetflixSecurity.cpp	Updates the INetflixSecurity implementation to Get* methods returning Core::hresult with out-parameters.
Source/cryptography/tests/cryptography_test/NetflixSecurityTests.cpp	Updates the test to use the new Get* APIs instead of direct-return getters.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-advanced-security]

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

• The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
• Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
• You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.