Rdkemw 24209 update hdcp status - #178
Open
santoshcomcast wants to merge 3 commits into
Open
santoshcomcast wants to merge 3 commits into
santoshcomcast wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
It appears to default release consumption to debug IPK feeds and the PR title doesn’t match the actual configuration-only changes.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates middleware IPK feed configuration to point at a new release identifier/build drop, affecting where images fetch middleware (and OSS middleware) packages from.
Changes:
- Update
RELEASE_NUMtoRDKEMW-24209-2. - Switch default middleware and OSS middleware IPK feed base paths from
middleware-rel/...tomiddleware-dbg/....
File summaries
| File | Description |
|---|---|
| conf/machine/include/oss_mw.inc | Changes default OSS middleware IPK feed path to middleware-dbg/${RELEASE_NUM}. |
| conf/machine/include/middleware.inc | Updates RELEASE_NUM and changes default middleware IPK feed path to middleware-dbg/${RELEASE_NUM}. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+10
to
11
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | ||
| MW_IPK_SERVER_PATH ?= "${RDK_ARTIFACTS_BASE_URL}/${MW_IPK_PATH}/${RDK_MW_ARCH}/ipks/${BUILD_VARIANT}" |
Comment on lines
+5
to
6
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | ||
| MW_OSS_IPK_SERVER_PATH = "${RDK_ARTIFACTS_BASE_URL}/${MW_OSS_IPK_PATH}/${RDK_MW_ARCH}/${MW_OSS}/ipks/${BUILD_VARIANT}" |
Comment on lines
+8
to
+10
| RELEASE_NUM = "RDKEMW-24209-2" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.