Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The changes redirect default feeds to a debug artifact path and hard-assign the release identifier in a way that can unintentionally impact all consumers and reduces downstream configurability.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the middleware IPK feed configuration to point at a debug artifact location and changes the configured release identifier used to build the feed URL paths.
Changes:
- Updated
MW_IPK_PATHandMW_OSS_IPK_PATHdefaults to usemiddleware-dbg/${RELEASE_NUM}instead of the prior release path. - Updated
RELEASE_NUMvalue toRDKEMW-24721, affecting the resolved feed URL directory.
File summaries
| File | Description |
|---|---|
conf/machine/include/oss_mw.inc |
Switches OSS middleware feed base path default to the debug artifact directory. |
conf/machine/include/middleware.inc |
Changes the release identifier and switches the main middleware feed base path default to the debug artifact directory. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| RELEASE_NUM = "RDKEMW-24721" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
| PACKAGE_EXTRA_ARCHS:append = " ${MW_OSS} " | ||
| OPKG_ARCH_PRIORITY:${MW_OSS} = "205" | ||
| MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
d0fb61c to
0b0c47f
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The changes alter the default artifact feed source to a debug channel in shared include files, which can have broad operational impact without an explicit config toggle.
Review details
Suppressed comments (2)
conf/machine/include/middleware.inc:11
- Defaulting MW_IPK_PATH to the debug feed and hard-coding a ticket-specific RELEASE_NUM in a shared include makes the default configuration environment-specific; it’s safer to keep a stable default and make the feed channel/RELEASE_NUM overrideable via local.conf/distro config without patching this file.
RELEASE_NUM = "RDKEMW-21379_MSNOW"
MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}"
MW_IPK_SERVER_PATH ?= "${RDK_ARTIFACTS_BASE_URL}/${MW_IPK_PATH}/${RDK_MW_ARCH}/ipks/${BUILD_VARIANT}"
conf/machine/include/oss_mw.inc:6
- MW_OSS_IPK_PATH now defaults to the debug feed, which changes the default artifact source for all OSS middleware package feeds; consider parameterizing the channel (rel vs dbg) similarly to middleware.inc so consumers can switch via config rather than editing this include.
MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}"
MW_OSS_IPK_SERVER_PATH = "${RDK_ARTIFACTS_BASE_URL}/${MW_OSS_IPK_PATH}/${RDK_MW_ARCH}/${MW_OSS}/ipks/${BUILD_VARIANT}"
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
No description provided.