Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Scope both feed overrides to the Element TE1 machine or distro configuration.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Updates middleware feed configuration to consume Element TE1 debug IPKs.
Changes:
- Sets the TE1 middleware release identifier.
- Redirects standard and OSS feeds to
middleware-dbgartifacts.
| File | Review |
|---|---|
conf/machine/include/middleware.inc |
Critical: Unconditionally applies TE1-specific release and debug feed settings to all consumers. |
conf/machine/include/oss_mw.inc |
Critical: Unconditionally redirects all OSS-enabled machines to the TE1-specific debug feed. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+8
to
+11
| RELEASE_NUM = "RDKEVD-9228-MW-EL-TE1-AV120-r1" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_SERVER_PATH ?= "${RDK_ARTIFACTS_BASE_URL}/${MW_IPK_PATH}/${RDK_MW_ARCH}/ipks/${BUILD_VARIANT}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | ||
| MW_IPK_SERVER_PATH ?= "${RDK_ARTIFACTS_BASE_URL}/${MW_IPK_PATH}/${RDK_MW_ARCH}/ipks/debug" |
Comment on lines
+5
to
+6
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | ||
| MW_OSS_IPK_SERVER_PATH ?= "${RDK_ARTIFACTS_BASE_URL}/${MW_OSS_IPK_PATH}/${RDK_MW_ARCH}/${MW_OSS}/ipks/debug" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.