RDKMVE-3274: Remove the meta-oss-common-config layer

[Nairisnotavailable]

Reason for change : Remove the meta-oss-common-config layer
Test Procedure : Build is successful
Priority : Unprioritized
Risks : None

[Copilot]

🟡 Changes recommended

The change content (remove OSS_EXT + add RDK_BLUETOOTH) does not align with the stated PR intent (remove meta-oss-common-config), and the new manifest variable appears to have no other references in-repo and needs confirmation.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates the Yocto layer template (bblayers.conf.sample) to modify which optional layers are included via manifest-provided paths.

Changes:

• Removes the conditional inclusion of the MANIFEST_PATH_OSS_EXT layer.
• Adds conditional inclusion of a new MANIFEST_PATH_RDK_BLUETOOTH layer.

File summaries

File	Description
conf/template/bblayers.conf.sample	Adjusts the template layer list by removing OSS_EXT and adding RDK_BLUETOOTH as an optional layer.

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🔵 Needs a closer look

The Bluetooth layer addition is outside the stated scope and may alter builds.

Review details

Suppressed comments (1)

conf/template/bblayers.conf.sample:30

• This change does more than remove the OSS layer: it adds MANIFEST_PATH_RDK_BLUETOOTH to the default layer set, even though the PR description only calls for removing meta-oss-common-config. That can silently pull an unrelated Bluetooth layer into builds whenever the manifest provides this path. Please delete this line rather than replacing the removed entry, unless adding Bluetooth is an explicitly intended part of the PR.

BBLAYERS =+ "${@'${MANIFEST_PATH_RDK_BLUETOOTH}' if os.path.isfile('${MANIFEST_PATH_RDK_BLUETOOTH}/conf/layer.conf') else ''}"

• Files reviewed: 1/1 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Copilot]

🔵 Needs a closer look

The unrelated Bluetooth layer addition changes layer composition and should be removed or explicitly justified.

Review details

Suppressed comments (1)

conf/template/bblayers.conf.sample:30

• This change does not only remove the OSS extension layer; it adds MANIFEST_PATH_RDK_BLUETOOTH to every generated layer configuration. When a manifest defines that variable, builds will now include an additional Bluetooth layer, changing layer composition and precedence despite no Bluetooth-related requirement or accompanying change in this PR. Please remove the old line without adding a replacement, unless this new layer is intentional and should be documented separately.

BBLAYERS =+ "${@'${MANIFEST_PATH_RDK_BLUETOOTH}' if os.path.isfile('${MANIFEST_PATH_RDK_BLUETOOTH}/conf/layer.conf') else ''}"

• Files reviewed: 1/1 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Copilot]

🔵 Needs a closer look

Remove the correct layer reference and avoid the unrelated Bluetooth substitution.

Review details

Suppressed comments (2)

conf/template/bblayers.conf.sample:30

• This hunk replaces the removed MANIFEST_PATH_OSS_EXT entry with MANIFEST_PATH_RDK_BLUETOOTH, so configurations that provide that manifest path will now load an additional Bluetooth layer. That is an unrelated behavior change to a PR whose stated purpose is only to remove meta-oss-common-config; delete this line rather than substituting another layer (or document and implement the Bluetooth dependency separately).

BBLAYERS =+ "${@'${MANIFEST_PATH_RDK_BLUETOOTH}' if os.path.isfile('${MANIFEST_PATH_RDK_BLUETOOTH}/conf/layer.conf') else ''}"

conf/template/bblayers.conf.sample:30

• This replaces MANIFEST_PATH_OSS_EXT, but the layer named in the PR (meta-oss-common-config) is still enabled through MANIFEST_PATH_CONFIG_COMMON on line 24. The changelog identifies MANIFEST_PATH_OSS_EXT as the meta-rdk-oss-ext layer, so this change does not remove the requested layer; remove the MANIFEST_PATH_CONFIG_COMMON entry instead, and add the Bluetooth entry only if that is a separate requirement.

BBLAYERS =+ "${@'${MANIFEST_PATH_RDK_BLUETOOTH}' if os.path.isfile('${MANIFEST_PATH_RDK_BLUETOOTH}/conf/layer.conf') else ''}"

• Files reviewed: 1/1 changed files
• Comments generated: 0 new
• Review effort level: Lite