Move remaining js1 build-* commands under the build namespace#57348
Open
javache wants to merge 2 commits into
Open
Move remaining js1 build-* commands under the build namespace#57348javache wants to merge 2 commits into
js1 build-* commands under the build namespace#57348javache wants to merge 2 commits into
Conversation
Summary: Hello Devmate, you are being invoked from a diff comment on diff D94367880. You should fetch the details of that diff to get the full context of the comment before proceeding. The comment content is below: #fileadiff Add back backwards compat for rawProps.at(x,y,z) Differential Revision: D109837388
Summary: Follow-up to the `js1 build-cxx-api` rename. Move `build-geo-screenshot-tests`, `build-js-api`, and `build-twui-screenshot-tests` under the `build` group so they sit next to their siblings (`js1 build assets`, `js1 build turbomodule`, etc.) instead of being top-level hyphenated outliers. Each old top-level command stays as a hidden alias that prints a deprecation notice and delegates to the new module, so existing muscle memory and any out-of-tree scripts keep working. Also updates the two places that emit the old command names into user-visible output: the TWUI template comment headers, and the JS API snapshot failure message. Changelog: [Internal] Differential Revision: D109844649
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109844649. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Follow-up to the
js1 build-cxx-apirename. Movebuild-geo-screenshot-tests,build-js-api, andbuild-twui-screenshot-testsunder thebuildgroup so they sit next to their siblings (js1 build assets,js1 build turbomodule, etc.) instead of being top-level hyphenated outliers.Each old top-level command stays as a hidden alias that prints a deprecation notice and delegates to the new module, so existing muscle memory and any out-of-tree scripts keep working.
Also updates the two places that emit the old command names into user-visible output: the TWUI template comment headers, and the JS API snapshot failure message.
Changelog:
[Internal]
Differential Revision: D109844649