feat(common): add skeleton loading state to FeaturedPlays#1713
Open
riteshrana12-dev wants to merge 1 commit intoreactplay:mainfrom
Open
feat(common): add skeleton loading state to FeaturedPlays#1713riteshrana12-dev wants to merge 1 commit intoreactplay:mainfrom
riteshrana12-dev wants to merge 1 commit intoreactplay:mainfrom
Conversation
👷 Deploy request for reactplayio pending review.Visit the deploys page to approve it
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey! contributor, thank you for opening a Pull Request 🎉.
@reactplay/maintainers will review your submission soon and give you helpful feedback.
If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have read the ReactPlay Contributor Guidelines and Discussion
I have reviewed the ReactPlay Code Review Checklist
I have tested my changes locally and verified there are no new warnings or errors
Description
The FeaturedPlays component was showing a plain "Loading..." text while
plays were being fetched. Replaced it with 4 skeleton loading cards that
match the exact shape of the PlayCard component including:
The skeleton uses a CSS shimmer animation to indicate loading state,
giving users a visual preview of the content structure before data loads.
Fixes #1712
Type of change
How Has This Been Tested?
Tested locally by running
npm start— skeleton cards are visible onthe home page while plays load. Verified with Chrome DevTools Network
throttling set to Slow 3G to clearly see the shimmer animation before
data loads in.
Linter passes clean with npm run lint:fix — 0 errors.
Checklist:
Screenshots
[Tested locally — shimmer skeleton cards visible on home page during load]