Decorator API#209
Merged
Merged
Conversation
- Observe Readium CSS changes - Handle font loading - Handle Chrome Zoom discrepancy in rects/positioning
TMP. will deal with this in new build.
- Use shadow DOM to isolate from Readium CSS - check and adjust contrast for all types - defaults specific to type
So that it can be easier to create highlights in FXL
Otherwise it is overflowing and clipped
Achievable through mask + Layout/Width options
Contributor
Author
|
cc @smoores-dev I know you have lots of experience with the API in Mobile so it will help tremendously if you could take a look. I tried filling in the gaps so that it stays aligned with Mobile toolkits but of course, you are way ahead on use cases, bugs, etc. 🙏 |
Contributor
Author
|
There will be more work happening on this but it should not impact the known public API, only the internals as we need to adjust for Readium Speech. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to implement the Decorator API per https://readium.org/architecture/proposals/008-decorator-api.html