Add toggle between logo and full title on click in details screen#2760
Open
VyomVyas4765 wants to merge 4 commits intorecloudstream:masterfrom
Open
Add toggle between logo and full title on click in details screen#2760VyomVyas4765 wants to merge 4 commits intorecloudstream:masterfrom
VyomVyas4765 wants to merge 4 commits intorecloudstream:masterfrom
Conversation
2 tasks
Author
|
Thanks for the feedback! That makes sense, I’ll refactor it to use result_title and bindLogo, and also fix the navigation issue. |
Author
|
The details you gave actually helped a bunch, appreciate it. I've reworked the logic to fix the layout judder by dropping the animations, and hooked it up to a LruCache so the toggle state persists across the RecyclerView. I also dropped the .isEnabled hack to prevent state bleeding and cleaned up the TV focus outlines. Let me know if this looks better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the feature for #2650 by adding a toggle on the logo to show the full title. Tapping the logo switches to the text title of the media and then tapping the title again brings the logo back. Nothing changes when there is no logo and the title itself is there. Tested and working as expected.