Skip to content

Adding back API timeout changes - #349

Open
yguntur-bot wants to merge 1 commit into
redhat-data-and-ai:mainfrom
yguntur-bot:DATA-7595-usernaut
Open

yguntur-bot wants to merge 1 commit into
redhat-data-and-ai:mainfrom
yguntur-bot:DATA-7595-usernaut

Conversation

@yguntur-bot

Copy link
Copy Markdown

Changes

📝 Description

What changed?

Adding back the API timeout changes which has been removed due to pod restarts happened last week

Why is this change needed?

Snowflake team has applied the patch to decrease the timeout errors and we should need to revert our old changes (#342)

Dependencies

  • N/A

🧪 Testing

Test Coverage

Performance Impact

  • N/A

🚀 Deployment

Deploy Steps

  1. N/A

Prerequisites

  • N/A

Post-Deployment Monitoring

  • N/A

Rollback Plan

  • N/A

⚠️ Breaking Changes

  • This PR contains breaking changes
  • Migration guide provided (if applicable)

Details:

  • N/A

⚙️ Configuration Changes

  • N/A

✅ Developer Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added positive and negative tests that prove my fix is effective or that my feature works
  • Relevant documentation (README, tech specs, etc.) has been added or updated
  • All CI/CD checks are passing

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: f81defd1-127f-4523-835f-33da89efae1a

📥 Commits

Reviewing files that changed from the base of the PR and between 5e748c5 and 5b36629.

📒 Files selected for processing (1)
  • pkg/clients/snowflake/client.go

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Snowflake polling operations now stop after five minutes if results are not available, preventing them from continuing indefinitely.

Walkthrough

The Snowflake client now creates a five-minute child context for request polling. When the deadline expires, polling returns a cancellation error instead of continuing indefinitely.

Changes

Snowflake polling control

Layer / File(s) Summary
Bound polling duration
pkg/clients/snowflake/client.go
makeRequestWithPolling passes a five-minute timeout context to pollForResults. Polling returns a "polling cancelled" error after the deadline.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to ef266

Snowflake polling now stops after five minutes rather than running indefinitely. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: restoring API timeout changes.
Description check ✅ Passed The description explains what changed and why. It uses the required template and records non-applicable sections, although test coverage details are not provided.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Yaswanth Guntur <yguntur@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant