Scorecard file level checks#2751
Draft
djanickova wants to merge 11 commits intoredhat-developer:mainfrom
Draft
Conversation
Contributor
|
This pull request adds a new top-level directory under |
Signed-off-by: Diana Janickova <djanicko@redhat.com> test: implement and update unit tests Assisted-By: Cursor Signed-off-by: Diana Janickova <djanicko@redhat.com> chore: generate api reports Signed-off-by: Diana Janickova <djanicko@redhat.com> ref: use metricId instead of providerId Signed-off-by: Diana Janickova <djanicko@redhat.com> ref: Apply suggestions from code review Co-authored-by: Ihor Mykhno <imykhno@redhat.com> fix: run prettier Signed-off-by: Diana Janickova <djanicko@redhat.com> fix: update expected string in test Signed-off-by: Diana Janickova <djanicko@redhat.com>
Signed-off-by: Diana Janickova <djanicko@redhat.com> feat: implement aggregated card and update test Signed-off-by: Diana Janickova <djanicko@redhat.com> feat: include aggregated card in App.tsx Signed-off-by: Diana Janickova <djanicko@redhat.com> fix: pass logger as param Signed-off-by: Diana Janickova <djanicko@redhat.com> ref: remove default boolean tresholds, edit translation Signed-off-by: Diana Janickova <djanicko@redhat.com> chore: generate api reports Signed-off-by: Diana Janickova <djanicko@redhat.com> test: e2e test scenario for file checks Signed-off-by: Diana Janickova <djanicko@redhat.com> fix: selectors in test Signed-off-by: Diana Janickova <djanicko@redhat.com> feat: include file check section in app-config.yaml Signed-off-by: Diana Janickova <djanicko@redhat.com> fix: aggregated permission card title and desc Signed-off-by: Diana Janickova <djanicko@redhat.com> ref: move tresholds from scorecard-common Signed-off-by: Diana Janickova <djanicko@redhat.com> fix: off center icon and treshold imports Signed-off-by: Diana Janickova <djanicko@redhat.com> feat: add new translations Signed-off-by: Diana Janickova <djanicko@redhat.com> ref: implement resolveMetricTranslation Signed-off-by: Diana Janickova <djanicko@redhat.com> fix: resolve translations correctly Signed-off-by: Diana Janickova <djanicko@redhat.com> ref: use useMemo in EmptyStatePanel Signed-off-by: Diana Janickova <djanicko@redhat.com> fix: use translations in test Signed-off-by: Diana Janickova <djanicko@redhat.com>
dd295a2 to
6a60828
Compare
Signed-off-by: Diana Janickova <djanicko@redhat.com>
Signed-off-by: Diana Janickova <djanicko@redhat.com>
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Signed-off-by: Diana Janickova <djanicko@redhat.com>
Signed-off-by: Diana Janickova <djanicko@redhat.com>
Signed-off-by: Diana Janickova <djanicko@redhat.com>
Signed-off-by: Diana Janickova <djanicko@redhat.com>
Signed-off-by: Diana Janickova <djanicko@redhat.com>
Signed-off-by: Diana Janickova <djanicko@redhat.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Hey, I just made a Pull Request!
This PR introduces a new type of scorecard: file level checks (RHDHPLAN-397). This adds ability for Scorecard to verify if a list of required files (one or more) is present (such as a license, CODEOWNERS, dockerfile, .gitignore, etc). The paths to these files are configurable.
Example of these scorecards on the entity page:

Example of these scorecards on homepage:

Example config:
The contents of this PR have been reviewed in 2 separate previous PRs within my fork:
djanickova#1
djanickova#2
✔️ Checklist