Repository navigation
Fix cache size warnings for bounded weakMapMemoize caches - #825
Open
LucasLeao18 wants to merge 1 commit into
Open
LucasLeao18 wants to merge 1 commit into
LucasLeao18 wants to merge 1 commit into
Conversation
✅ Deploy Preview for reselect-docs canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
weakMapMemoize(fn, { maxSize: 1002 }), adding 1001 distinct primitive arguments triggers a warning that the cache will grow without bound and recommends settingmaxSize, even though it is already set.Skip the unbounded-growth warning when generational bounding is enabled. Tests exercise
onceandalways, multiple generations, andclearCache(). Existing checks still verify warnings for unbounded caches.Validation on Node 24.15.0 / Windows:
pnpm test: 139 runtime tests and 29 type tests passed, plus the loose-null-checks compiler run.pnpm lintandpnpm format:check: passed.Prepared with OpenAI Codex; tests were run locally.