Repository navigation
docs: fix broken links to API anchors and removed middleware sections - #15614
Open
SatvikMishra08 wants to merge 1 commit into
Open
SatvikMishra08 wants to merge 1 commit into
SatvikMishra08 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A link check of reactrouter.com turned up a few in-page links in the hand-written docs that don't land anywhere:
how-to/error-reporting:HydratedRouter#onErrorandRouterProvider#onError→#onerror(the generated API pages use lowercase ids)how-to/middleware:createBrowserRouter#optsgetContext→#optsgetcontextupgrading/v7: thefuture.v8_middlewaresection linked to#changes-to-getloadcontextapploadcontextand#migration-from-apploadcontext, but those sections are no longer in the middleware guide. I pointed it at the current "Add agetLoadContextfunction (if applicable)" section, which shows returning aRouterContextProvider.The Data mode bullet just below still links to
#1-typescript-augment-future-for-loaderaction-context, which is also gone. I left it alone because I wasn't sure whether theFutureaugmentation step still applies or the bullet should be dropped. Happy to update it either way.