fix: guard against undefined logicalLineInfo#15
Open
hyldmo wants to merge 1 commit intoremorses:mainfrom
Open
Conversation
…ollPositionForLine The native `logicalLineInfo` getter can return undefined when the text buffer view hasn't completed layout yet (e.g. during initial render or rapid pane switching). This causes an unhandled rejection crash on `lineInfo.lineStarts.length`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
This seems to happen somewhat intermittently, so it's a bit hard to trace down. However for some reason when i see it happening, it usually persists accross restarts (of my app that is). don't really have a repro, but this is the project i use it in: https://github.com/hyldmo/numux |
hyldmo
added a commit
to hyldmo/numux
that referenced
this pull request
Mar 23, 2026
The existing patch only covered src/ but Bun can resolve to dist/ in some setups. Also print stack traces instead of just messages in unhandled rejection handlers. Upstream: remorses/ghostty-opentui#15 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logicalLineInfocan returnundefinedwhen the native text buffer view hasn't completed layout yet (e.g. during initial render or rapid pane switching)renderSelfcrashes with unhandled rejection onlineInfo.lineStarts.lengthgetScrollPositionForLinehas the same issueFix
lineStarts.lengthaccess inrenderSelfwithif (lineInfo)guardlineInfo?.lineStarts) ingetScrollPositionForLine🤖 Generated with Claude Code