Address github rate limitting when releasing - #441
Open
divolgin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Release workflow can fail due to Github rate limiting. Changes below address this issue.
Securebuild FIPS Image Build Failure - Fix Summary
Problem
The
replicated-sdk-fipsmatrix job inpublish-securebuild.ymlfailed with./securebuild: line 1: Not: command not found(exit code 127). Thereplicated-sdkjob in the same run succeeded.Root Cause
Both matrix jobs run in parallel and each makes an unauthenticated GitHub API call to fetch the latest securebuild release tag. With multiple jobs hitting the API simultaneously, one job got rate-limited (unauthenticated calls are capped at ~60 req/hr per IP), causing
jq -r .tag_nameto returnnull. The resulting download URL pointed to a non-existent asset, andcurl -sL(without the-fflag) silently saved the "Not Found" error page as thesecurebuildbinary.chmod +xsucceeded on the text file, but execution failed on the first word ("Not").Fix
Updated both "Install securebuild CLI" steps in
.github/workflows/publish-securebuild.yml:GITHUB_TOKENas a Bearer token, raising the rate limit to 5,000 req/hrcurl -fflag — fail on HTTP errors instead of silently saving error responsesLATEST_TAGis empty ornullfilebefore proceeding, printing contents on failure for debuggingDoes this PR introduce a user-facing change?