Wire deployment pod-spec names to replicated.name helper - #445
Merged
banjoh merged 1 commit intoJul 30, 2026
Merged
Conversation
Container, volume, and volumeMount names in the Deployment were hardcoded to "replicated", so nameOverride/alias rebranded the Kubernetes object names but left the pod-spec fields showing the literal "replicated" name. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
banjoh
enabled auto-merge (squash)
July 30, 2026 11:43
sgalsaleh
approved these changes
Jul 30, 2026
banjoh
deleted the
evansmungai/sc-139090/replicated-sdk-wire-deployment-pod-spec-names
branch
July 30, 2026 15:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Points the Deployment's
volumes[].name,containers[].name, andvolumeMounts[].namefields at the existingreplicated.namehelper instead of the hardcoded literalreplicated, sonameOverride/subchart alias rebrands the pod-spec fields too, not just the Kubernetes object names.Out of scope (per the linked story): config file path,
REPLICATED_*env vars, image domain, and other internal-only strings.Verified via
helm templatewithnameOverrideand as an aliased subchart — volume/container/volumeMount all pick up the override, volume/volumeMount stay matched,helm lintpasses.Fixes sc-139090.
Does this PR introduce a user-facing change?