Skip to content

Fix flaky test by using strings instead of symbols for JSON-serialized args - #813

Merged
PatrickTulskie merged 2 commits into
resque:masterfrom
top-sigrid:fix-flaky-symbol-test
Sep 24, 2026
Merged

PatrickTulskie merged 2 commits into
resque:masterfrom
top-sigrid:fix-flaky-symbol-test

Conversation

@top-sigrid

Copy link
Copy Markdown
Contributor

Fixes a flaky test on Ruby 2.4 where mocha expectations fail due to symbol/string mismatch.

@top-sigrid
top-sigrid force-pushed the fix-flaky-symbol-test branch from 8d5b47e to 05d823c Compare July 23, 2026 15:37
@top-sigrid

Copy link
Copy Markdown
Contributor Author

@PatrickTulskie I also rebased this, with ruby versions 2.* not being supported anymore, these aren't flaky anymore, so I leave this up to you, if this still makes sense :)

@PatrickTulskie
PatrickTulskie merged commit d61c7da into resque:master Sep 24, 2026
73 checks passed
@PatrickTulskie PatrickTulskie added this to the v5.0.1 milestone Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants