feat(rivetkit): trace actor to actor calls - #5732
eersnington wants to merge 1 commit into
Conversation
Review: feat(rivetkit): trace actor to actor callsReviewed the diff across Correctness
Coverage gap worth a second look
Test coverage
Minor nits
No security concerns — 🤖 Generated with Claude Code |
bc77372 to
384b32b
Compare
There was a problem hiding this comment.
🟠 2 medium-severity findings
Reviewed commit 384b32b.
🟠 Medium · Keep outbound call tracing available on wasm
Every client created inside a wasm-hosted actor now receives beginOutboundCall, but this adapter always returns undefined. Its action calls therefore continue to propagate the invocation context directly and never emit the new client span, unlike the NAPI runtime.
Expose the core context operation through the wasm binding and forward it here (including its span and finish), rather than using this placeholder, so the portable CoreRuntime contract has the same tracing behavior on both runtimes.
Original location: "rivetkit-typescript/packages/rivetkit/src/registry/wasm-runtime.ts":550 (new side, not submitted inline).
384b32b to
7f1d947
Compare
7f1d947 to
41a28e0
Compare
41a28e0 to
945ecce
Compare
945ecce to
8395b1b
Compare
8395b1b to
d485500
Compare
d485500 to
f9dcaf3
Compare
f9dcaf3 to
ae9c32e
Compare
ae9c32e to
241f2c1
Compare
241f2c1 to
9d7ac37
Compare
| _actorName: string, | ||
| _actionName: string, | ||
| ): RuntimeOutboundCall | undefined { | ||
| return undefined; | ||
| } | ||
|
|
There was a problem hiding this comment.
🟠 Medium · Keep outbound call tracing available on wasm
Every actor client now receives beginOutboundCall, but this adapter always returns undefined. Actions issued by wasm-hosted actors therefore still propagate the invocation span directly and never emit the new client span, unlike the NAPI runtime.
Forward the core context operation through the wasm binding (including its span context and finish operation) rather than returning this placeholder so the portable CoreRuntime contract has matching tracing behavior.
9d7ac37 to
aeeb217
Compare
aeeb217 to
e143d11
Compare
e143d11 to
6f7295c
Compare
Uh oh!
There was an error while loading. Please reload this page.