Skip to content

fix(android): map pans after long-press instead of staying fixed like on iOS#4197

Open
mariusud wants to merge 1 commit into
rnmapbox:mainfrom
mariusud:fix/android-long-press-drag-clean
Open

fix(android): map pans after long-press instead of staying fixed like on iOS#4197
mariusud wants to merge 1 commit into
rnmapbox:mainfrom
mariusud:fix/android-long-press-drag-clean

Conversation

@mariusud
Copy link
Copy Markdown
Contributor

@mariusud mariusud commented Apr 22, 2026

Description

On iOS, long-pressing an item on the map and dragging keeps the map fixed. On android the gesture is allowed through and the map pans instead.

As discussed in #3981.

This PR brings android to feature parity with iOS by consuming the move gesture after a long-press.
To test:

  • Long-press a feature on the map
  • Without lifting your finger, drag — the map should stay fixed and the feature should follow your finger
  • This already works on iOS - android should now behave the same way

@mariusud mariusud requested a deployment to CI with Mapbox Tokens April 22, 2026 12:34 — with GitHub Actions Waiting
@mariusud mariusud requested a deployment to CI with Mapbox Tokens April 22, 2026 12:34 — with GitHub Actions Waiting
@mariusud mariusud requested a deployment to CI with Mapbox Tokens April 22, 2026 12:34 — with GitHub Actions Waiting
@mariusud mariusud changed the title fix(android): map pans after long-press instead of staying fixed like on iOS#4196 fix(android): map pans after long-press instead of staying fixed like on iOS Apr 22, 2026
@mfazekas
Copy link
Copy Markdown
Contributor

Thanks for working on this! The main issue is that mAfterLongPress is set on every long press (including empty map space), which will block panning after any long press — not just on features/markers. Also onMoveBegin isn't guarded so mapGestureBegin still fires, but onMoveEnd returns early skipping mapGestureEnd, which can leave isGestureActive stuck at true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants