Skip to content

oauth issuer import: a refused attribute is only a warning (config-manager push now fails) #1350

Open

Description

@vscheuber

Summary

Follow-up to #1338 and the pull request that fixed it for frodo config-manager push oauth-issuers. The library (5.0.0-47) retries a write of an OAuth2 trusted JWT issuer without an attribute that the server refuses, prints a warning and stores the issuer without that attribute; a caller that must not store less than it was given passes the callback leftOutCallback(issuerId, attributes). config-manager push oauth-issuers now passes it, prints the refused attributes and fails (exit 1, unless --allow-failures). The separate command family frodo oauth issuer import imports issuers through the same library functions and does not pass the callback, so a refused attribute there still only prints the library's warning and the command reports success.

What to do

Decide, and say in the pull request, which behaviour frodo oauth issuer import should have: the same as the config-manager push (name the refused attributes, count the issuer as a failure, --allow-failures to accept it), or a warning only (the library's text, today). If the first: pass the callback in the ops function that the command calls, with the same message and the same failure rule as src/ops/OAuth2TrustedJwtIssuerConfigOps.ts, tests for the three cases (nothing refused, an attribute refused, an attribute refused with failures allowed), and a line in the help of the command.

Acceptance

  • The decision is written in the pull request; npm run check, npx tsc --noEmit, npm test pass.

Related: #1338, #1256, #1254.

Activity

  1. added
    enhancementNew feature or request
    no-auto-processingConcierge never touches this item; remove the label to hand it over
    on Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestno-auto-processingConcierge never touches this item; remove the label to hand it over

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions