Repository navigation
test(e2e): the pull all replays name the agent kind steps; live outcomes of #1260 items 10 and 11 - #1359
Merged
Conversation
…cordings predate The Cloud and ForgeOps pull all replays fail the steps oauth-cimd-profiles, oauth-issuers and oauth-software-publishers because the recordings predate them (9 of 39 and 12 of 33 steps), and the pull all-static replays do not run them (dynamic kinds). The comments of the tests say so, with what a live check on a development tenant showed (frodo-cli#1260). No recording or snapshot changes; the recordings come back with frodo-cli#1102. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1260 (the second half of its live checklist) and of #1355 (the live round trip on a tenant).
This pull request holds no recording, fixture or snapshot: the live session changed nothing that is recorded. It adds comments to the two
pull alltests (B3 of #1260: "re-record with #1102 or add the new step to the comments"). I took the second option on purpose: re-recordingpull allis #1102 (the whole configuration of a tenant and, for the second recording, a ForgeOps tenant).What the comments say, and why it is true
Read from the replays with the harness output switched on for one run each (not committed): the Cloud
pull allreplay exits 1 with9 of 39 steps failed(themes,oauth-cimd-profiles,oauth-issuers,oauth-software-publishers, connector-definitions, oauth2-agents, connector-mappings, saml, applications); the ForgeOps replay12 of 33 steps failed, the same three new steps among them; thepull all-staticreplays2 of 24 steps failed(org-privileges, password-policy) and none of the three kinds, which are dynamic and not steps of it. The three kinds fail in thepull allreplays because the requests they start with are not in the recordings.The replays pass unchanged:
config-manager-pull-all*,config-manager-pull-oauth2-agents,config-manager-push-oauth2-agents: 4 suites, 7 tests, 2924 snapshots, nothing obsolete. I read the snapshot entries that they carry from #1259 and #1355: no"inherited"wrapper in any agent file entry; no TrustedJwtIssuer file entry inpull allorpull oauth2-agents(skipped); six skip warnings in thepush oauth2-agentsstderr snapshot.Live outcomes on a development tenant (realm alpha, the throw-aways
zz-live-issuerandzz-live-rcaonly)pull allwith a config folder whoseoauth2-agents.jsonlists the issuer: exit 0, the issuer once in the tree (written by theoauth-issuersstep), ONE skip warning from the generic step; a secondpull allis identical except a file of another session's CIMD profile;pull all-static: 0 issuer files and no agents folder.pull oauth2-agentswith an issuer entry: the warning, exit 0, no file, no request for the type;push oauth2-agentsfrom a tree holding only the issuer: the warning, exit 0, only the login requests: nothing read or written.RemoteConsentAgent(no secret property among its 15 properties): the pulled file is plain; pushing it back and, after a delete, creating it from it, both give a byte-identical pull. AM adds two properties after the create (pushedConsentAuthenticationMethod,resourceOwnerSessionProperties: {}), which round trip too.zz-prefix.The full table with the evidence is in the maintainer's outcomes file of this session; the observations:
push oauth-issuersprints nothing on success; the generic route has no config-manager delete, so the throw-away was removed with a namedfrodo agent delete -i;pull oauth2-agentsstill names its config file option-f, --file(P4 of #1264).Verification
npm test(whole suite, one run under the suite lock, scratch HOME): exit 0; 1097 suites passed, 10 skipped; 10795 tests passed, 149 skipped; 10279 snapshots passed.npm run test:guidance: 3 suites, 693 tests passed.mainby comment lines only (14 added lines); the replays of the three tests that carry the entries reviewed above pass.