Skip to content

test(e2e): the pull all replays name the agent kind steps; live outcomes of #1260 items 10 and 11 - #1359

Merged
vscheuber merged 1 commit into
mainfrom
test/oauth-issuers-pull-all-replays
Nov 16, 2026
Merged

vscheuber merged 1 commit into
mainfrom
test/oauth-issuers-pull-all-replays

Conversation

@vscheuber

Copy link
Copy Markdown
Contributor

Part of #1260 (the second half of its live checklist) and of #1355 (the live round trip on a tenant).

This pull request holds no recording, fixture or snapshot: the live session changed nothing that is recorded. It adds comments to the two pull all tests (B3 of #1260: "re-record with #1102 or add the new step to the comments"). I took the second option on purpose: re-recording pull all is #1102 (the whole configuration of a tenant and, for the second recording, a ForgeOps tenant).

What the comments say, and why it is true

Read from the replays with the harness output switched on for one run each (not committed): the Cloud pull all replay exits 1 with 9 of 39 steps failed (themes, oauth-cimd-profiles, oauth-issuers, oauth-software-publishers, connector-definitions, oauth2-agents, connector-mappings, saml, applications); the ForgeOps replay 12 of 33 steps failed, the same three new steps among them; the pull all-static replays 2 of 24 steps failed (org-privileges, password-policy) and none of the three kinds, which are dynamic and not steps of it. The three kinds fail in the pull all replays because the requests they start with are not in the recordings.

The replays pass unchanged: config-manager-pull-all*, config-manager-pull-oauth2-agents, config-manager-push-oauth2-agents: 4 suites, 7 tests, 2924 snapshots, nothing obsolete. I read the snapshot entries that they carry from #1259 and #1355: no "inherited" wrapper in any agent file entry; no TrustedJwtIssuer file entry in pull all or pull oauth2-agents (skipped); six skip warnings in the push oauth2-agents stderr snapshot.

Live outcomes on a development tenant (realm alpha, the throw-aways zz-live-issuer and zz-live-rca only)

The full table with the evidence is in the maintainer's outcomes file of this session; the observations: push oauth-issuers prints nothing on success; the generic route has no config-manager delete, so the throw-away was removed with a named frodo agent delete -i; pull oauth2-agents still names its config file option -f, --file (P4 of #1264).

Verification

  • npm test (whole suite, one run under the suite lock, scratch HOME): exit 0; 1097 suites passed, 10 skipped; 10795 tests passed, 149 skipped; 10279 snapshots passed.
  • npm run test:guidance: 3 suites, 693 tests passed.
  • The two changed files differ from main by comment lines only (14 added lines); the replays of the three tests that carry the entries reviewed above pass.
  • Nothing is committed from the tenant: no recording, no fixture, no pulled file; the curl logs of the session (kept outside the repository) hold no bearer token or JWT.
  • Not checked: the question of feat(config-manager): agent files are written in the plain shape (record 0054) #1358 about a group object whose members were all left out (no group object in the two types used), and anything for CIMD profiles and software publishers (their own sessions).

…cordings predate

The Cloud and ForgeOps pull all replays fail the steps oauth-cimd-profiles,
oauth-issuers and oauth-software-publishers because the recordings predate
them (9 of 39 and 12 of 33 steps), and the pull all-static replays do not run
them (dynamic kinds). The comments of the tests say so, with what a live check
on a development tenant showed (frodo-cli#1260). No recording or snapshot
changes; the recordings come back with frodo-cli#1102.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@vscheuber vscheuber added the no-auto-processing Concierge never touches this item; remove the label to hand it over label Nov 16, 2026
@vscheuber
vscheuber merged commit 6c686e8 into main Nov 16, 2026
23 checks passed
@vscheuber
vscheuber deleted the test/oauth-issuers-pull-all-replays branch November 16, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-auto-processing Concierge never touches this item; remove the label to hand it over

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant