Repository navigation
test(e2e): record the oauth-software-publishers kind and settle its live checklist - #1360
Merged
Merged
Conversation
…lishers kind Recorded on a development tenant with the throw-away software publisher zz-e2e-publisher in the alpha realm, in the order push, pull, delete; the fixture is a real pull of that object (plain shape). Part of #1357. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1357. This is the maintainer's recording and live-check session for the kind
oauth-software-publishers(#1343), run on a development tenant after #1358 (agent files in the plain shape). The issue stays open for the maintainer to read the outcomes and decide; nothing in it is closed or ticked here.What is in the pull request
One commit: the e2e tests
config-manager-{push,pull,delete}-software-publishers, their three snapshots, nine recordings (three per command:am,openidm,environment) and the fixturetest/e2e/exports/fr-config-manager/cloud/realms/alpha/realm-config/agents/SoftwarePublisher/zz-e2e-publisher.json, which is a real pull of the throw-away object (plain shape,example.comvalues, no key). Recorded in the order push, pull, delete (FRODO_TEST_NAMEpushOne,pullOne,deleteOne, the commands are in the header comment of each test); afterwards the tenant no longer heldzz-e2e-publisher. No production code, no other snapshot and no other recording changed. Thepull allreplay needs no new sentence: its comment already names this step (#1343).Outcomes of the live checklist of #1357
Only the throw-away publishers
zz-live-publisherandzz-e2e-publisherwere written; the realm also holds a publisher that is not a throw-away and was only read; the listings of agents, trusted JWT issuers, CIMD profiles and OAuth2 clients are identical before and after. In short:No software publishers found.(exit 0), and-nof a missing one exits 1. A publisher is created from a hand-written file without_type. The pulled file is plain, has no_rev, and a named pull equals the pull of the realm byte for byte; two pulls give no diff; it equals theagentobject offrodo agent export(which adds_revand a volatilemetablock). Delete, then push the pulled file: the object is created again and equals the earlier pull (the second write left nothing out). A file of another_typeis refused before anything is sent.pull allhas the publisher once and a second run gives the same publisher folder;pull all-statichas no agents folder.pull oauth2-agentsandpush oauth2-agentsskip the type with one warning and send no request to an agents path.jwkSet. The pull writes it into the file and warns, without ever printing it; an override placeholder takes it out of the file; a push of a file withoutjwkSetremoves it from the object. Core 0013 says secrets are never exported in the clear: should the pull refuse or redactjwkSetthat holds private key material by default? (The vendor documentation describesjwkSetas the publisher's public keys.)--dry-run, named delete and the second delete (exit 1, not found) behave as written. The option is--dry-runonly: the-din the issue text does not exist. Not run: the unnamed delete, the-ybulk form and the refusal without a terminal, because the realm holds a publisher that is not a throw-away; the unit tests and the delete guard tests cover them.Decisions taken (reversible)
pull allreplay is re-recorded (Re-record the config-manager pull all and pull all-static recordings: five steps fail on replay #1102); no sentence added (it exists).Verification
npm run checkexit 0;npx tsc --noEmitexit 0;npm run test:guidance3 suites, 693 passed.Bearer <bearer token>; no private key, JWT or password value. As in the existing recordings, the login read of the service account object contains its description (which names the person who created it) and its public key; no recording was edited.Not verified
Unnamed and bulk deletes on a tenant; the schema of the type (no tool);
inherited: true(none in a publisher); CIMD or issuer behaviour (other sessions).