fix: Prevent IndexOutOfBoundsException in paging by enforcing item ID uniqueness#20
Merged
Merged
Conversation
… uniqueness ListMerger.reorderNonFinalItems assumed a 1:1 correspondence between target-list positions matching newIds and the new-item anchors. Duplicate item IDs (within a page, the same item across pages with live pagination, or externally intercepted values) broke that invariant and crashed with "Index N out of bounds for length N". Deduplicate by itemId at every point that produces the output list (getNonFinalItems, ListMerger input/result, and intercept), and guard the reorder loop, so the emitted list always has unique IDs. This also avoids Compose LazyColumn/LazyRow key-collision crashes downstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListMerger.reorderNonFinalItems assumed a 1:1 correspondence between target-list positions matching newIds and the new-item anchors. Duplicate item IDs (within a page, the same item across pages with live pagination, or externally intercepted values) broke that invariant and crashed with "Index N out of bounds for length N".
Deduplicate by itemId at every point that produces the output list (getNonFinalItems, ListMerger input/result, and intercept), and guard the reorder loop, so the emitted list always has unique IDs. This also avoids Compose LazyColumn/LazyRow key-collision crashes downstream.