Add "when-end" command to get the number of the last event#4084
Merged
Conversation
Collaborator
|
I think this caused that test failure in |
timo
force-pushed
the
when-end_command
branch
2 times, most recently
from
July 22, 2026 13:38
7217770 to
8bbb72c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when-end gives the event number of the last event in the whole recording.
This is useful when running a replay with non-stopping breakpoints and displaying the "progress" of the replay to the user.
I'm not actually sure if
result.type() == TraceTaskEvent::Type::NONEis an idiomatic way to see if theread_task_eventcall returned the "default value" of that type. But it does at least seem to work in the cases I've tested.