Fix check-depends-only failure by correcting tryCatch error handler signature in shiny version guard#101
Draft
Fix check-depends-only failure by correcting tryCatch error handler signature in shiny version guard#101
check-depends-only failure by correcting tryCatch error handler signature in shiny version guard#101Conversation
Agent-Logs-Url: https://github.com/rstudio/reactlog/sessions/45b96050-c7e1-45e9-8108-d5800f5bc8d9 Co-authored-by: karangattu <4220325+karangattu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing checks for reactlog package on main
Fix Apr 17, 2026
check-depends-only failure by correcting tryCatch error handler signature in shiny version guard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scheduled package checks from
shinycorecistarted failing onmaininR-CMD-check / check-depends-only. The failure came fromtest_shiny_version()raisingunused argument (cond)whenshinyis absent andtryCatchinvokes the error handler with a condition argument.Root cause
test_shiny_version()used anerrorhandler with zero parameters (function()), which is incompatible with condition-passing handler invocation.Code change
R/shinyModule.Rto accept the condition argument and continue returningFALSEwhenshinyis unavailable.shinyis not installed) while removing the runtime error in depends-only checks.Patch snippet