Enforce frozen_string_literal comment and enable performance cops#255
Closed
Enforce frozen_string_literal comment and enable performance cops#255
Conversation
Every file in this project already uses `# frozen_string_literal: true` but the linter never enforced it, so new files could silently omit the comment. Enable the Style/FrozenStringLiteralComment cop via standardrb's extend_config mechanism to make the existing convention a hard rule. Also add rubocop-performance to catch common performance anti-patterns like inefficient string operations and unnecessary object allocations.
33f519c to
1593165
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every Ruby file in this project already includes
# frozen_string_literal: true, but the linter never enforced that convention. This means new files could silently omit the comment without CI catching it.This PR uses standardrb's
extend_configto layer additional RuboCop rules on top of the existing Standard configuration:# frozen_string_literal: truecomment on every file, codifying the existing project convention.flat_map, and similar patterns.No source files needed to change because the convention was already universally followed.