Repository navigation
5372 alignment nudges2 - #5398
Merged
Merged
Conversation
…ons column modified _partner_row.html.erb to have status buttons span the whole column ( talked to brock) modified kits/_table.html.erb to use class="text-right" for its ations column
Only done the frist bullet (partial completion) "Actions" should always be right-justified, but some pages it is left-justified or centered. Modified many files to keep data right justified as wel as keeping actions headers and their buttons right justified
…be right justified. Made quantity and integer values in sub table right justified
…teger data and header to be right justified
…and left-justified
… be left justified and date class
…e dates both date and text-left class
…ied and date class modified partners table quota integer data to be right justified modified request row # of items to be right justified
…bsp;</th> at the end for consistency
…eader instead of blank space in actions column
…ht justified and fixed error in kits
Contributor
Author
|
Please resolve #5390 first, this will allow me to clean up the commits for this ticket a little bit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially Resolves #5372
Description
Finished modifying the following from the ticket:
1/ "Actions" should always be right-justified, but some pages it is left-justified or centered.
2/ Square footage should be right-justified
3/ Sometimes we are left-justifying dates, and sometimes we are right justifying them. Let's always left-justify them.
4/ Audits -- quantities (and headings) should be right-justified.
5/ Total Items on Product Drive Participants and Vendors pages should be right justified
Type of change
How Has This Been Tested?
Changes were viewed locally to test they passed.
Screenshots