Skip to content

5086 Rename Executive Director to Contacts in Partner Profile - #5412

Merged
janeewheatley merged 10 commits into
rubyforgood:mainfrom
hagiya0121:5086/rename-executive-director-to-contacts
Nov 23, 2025
Merged

janeewheatley merged 10 commits into
rubyforgood:mainfrom
hagiya0121:5086/rename-executive-director-to-contacts

Conversation

@hagiya0121

@hagiya0121 hagiya0121 commented Sep 27, 2025 •

Copy link
Copy Markdown
Contributor

Resolves #5086

Description

Renamed the Executive Director section to Contacts.

  • Why: The section contained not only Executive Director details but also the Primary Contact, so the old name no longer matched its contents.
  • Changes:
  • Updated partials, views, and forms to use contacts
  • Added a migration to update existing partner_form_fields
  • Adjusted system and service specs
  • Updated the user guide

Type of change

  • This change requires a documentation update
  • Documentation update

How Has This Been Tested?

  • Updated existing system specs and service specs to reflect the rename; all tests are passing.
  • Manually verified that the Contacts section renders correctly in both step form and edit form.

Screenshots

image image image

@hagiya0121
hagiya0121 force-pushed the 5086/rename-executive-director-to-contacts branch from 911bf62 to 03101f4 Compare September 29, 2025 12:36
@hagiya0121 hagiya0121 changed the title Rename Executive Director to Contacts in Partner Profile 5086 Rename Executive Director to Contacts in Partner Profile Sep 30, 2025
@hagiya0121
hagiya0121 marked this pull request as ready for review September 30, 2025 12:29
@hagiya0121 hagiya0121 moved this from In Progress to レビュー中 in OSS Contributions Oct 2, 2025

@dorner dorner left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review OK - over to @awwaiid for functional.

@dorner
dorner requested a review from awwaiid October 3, 2025 19:16
@janeewheatley

janeewheatley commented Nov 1, 2025 •

Copy link
Copy Markdown
Collaborator

@hagiya0121 TODO: I'm noticing that the User Guide image wasn't updated here with Contacts instead of Executive Director:
image

You can find this image at partner_profile_edit_initial.png.

@janeewheatley

Copy link
Copy Markdown
Collaborator

Thanks, @hagiya0121! Can you please check the specs?

@hagiya0121

Copy link
Copy Markdown
Contributor Author

Looks like the failing system specs are also failing on main, so they don’t appear to be caused by the changes in this PR.

@janeewheatley
janeewheatley merged commit 7e00c2e into rubyforgood:main Nov 23, 2025
12 checks passed
@github-project-automation github-project-automation Bot moved this from レビュー中 to 完了 in OSS Contributions Nov 23, 2025
@hagiya0121
hagiya0121 deleted the 5086/rename-executive-director-to-contacts branch November 29, 2025 03:16
@github-actions

Copy link
Copy Markdown
Contributor

@hagiya0121: Your PR 5086 Rename Executive Director to Contacts in Partner Profile is part of today's Human Essentials production release: 2025.11.30.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename Executive Director section on Profile to Contacts

4 participants