ch01: add cargo fetch to the working-offline setup steps - #4820
Open
okxint wants to merge 1 commit into
Open
Conversation
`cargo add` only updates Cargo.toml / Cargo.lock; it does not download the crate archives. Without a subsequent fetch or build, `--offline` fails with "attempting to make an HTTP request". Add `cargo fetch` as a fourth step so readers actually cache the .crate files before going offline, and update the surrounding prose to match (plural "these commands", "download and cache" instead of "cache the downloads"). Fixes rust-lang#4817
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Working Offline with This Book" section instructs readers to run
cargo add rand@0.10.1 trpl@0.2.0to cache dependencies, butcargo addonly updatesCargo.tomlandCargo.lock— it does not download the.cratearchives. As a result, subsequentcargocommands with--offlinefail because the crate files are not present in the local registry.Fixes #4817.
Changes
cargo fetchas a fourth step aftercargo add, which downloads and caches the.cratefiles locally