-
Notifications
You must be signed in to change notification settings - Fork 73
Add --print=all-target-specs-json unstable flag #600
Copy link
Copy link
Closed
Labels
T-compilerAdd this label so rfcbot knows to poll the compiler teamAdd this label so rfcbot knows to poll the compiler teammajor-changeA proposal to make a major change to rustcA proposal to make a major change to rustcmajor-change-acceptedA major change proposal that was acceptedA major change proposal that was accepted
Description
Activity
Metadata
Metadata
Assignees
Labels
T-compilerAdd this label so rfcbot knows to poll the compiler teamAdd this label so rfcbot knows to poll the compiler teammajor-changeA proposal to make a major change to rustcA proposal to make a major change to rustcmajor-change-acceptedA major change proposal that was acceptedA major change proposal that was accepted
Proposal
This MCP proposes to add the unstable
--print=all-target-specs-jsoncompiler flag in addition to the existing unstable--print=target-spec-jsonflag. The flag will output to the standard output the JSON representation of all builtin target specs, emitting a (sorted) map with the target name as the key and the target spec as the value:{ "aarch64-apple-darwin": { "abi-return-struct-as-int": true, "arch": "aarch64", ... }, "aarch64-apple-ios": { "abi-return-struct-as-int": true, "arch": "aarch64", ... }, ... }This is needed by rust-lang/rust#108905, as it needs to know the details of all targets in order to validate compiletest directives like
only-windowsandignore-x86_64. The alternative of invoking--print=target-listand then iterating each target with--print=target-spec-jsontakes around 5 seconds on my machine, which is not great.Mentors or Reviewers
If you have a reviewer or mentor in mind for this work, mention then
here. You can put your own name here if you are planning to mentor the
work.
Process
The main points of the Major Change Process are as follows:
@rustbot second.-C flag, then full team check-off is required.@rfcbot fcp mergeon either the MCP or the PR.You can read more about Major Change Proposals on forge.
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.