fix(links): warn when ANCHOR region closed with duplicate start (#2778)#3112
Closed
leno23 wants to merge 1 commit into
Closed
fix(links): warn when ANCHOR region closed with duplicate start (#2778)#3112leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
Log a warning when a region opened with `ANCHOR: name` encounters another `ANCHOR: name` instead of `ANCHOR_END: name`, and document via test that only ANCHOR_END closes the region (duplicate starts do not). Fixes rust-lang#2778 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies anchor region handling for
#include/rustdoc_include:ANCHOR_END: namecloses a region opened withANCHOR: nameANCHOR: nameinside the region logs a warning (it does not close the region)ANCHOR_ENDbehave differently when trailing lines existFixes #2778
Test plan
cargo test -p mdbook-driver duplicate_anchorcargo test -p mdbook-driver take_anchoredMade with Cursor