internal: Break hir-ty up, step 1 - #23181
Open
ChayimFriedman2 wants to merge 1 commit into
Open
Conversation
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
force-pushed
the
breakup-hir-ty-step1
branch
2 times, most recently
from
August 18, 2026 12:28
3677a0d to
c9d552f
Compare
This comment has been minimized.
This comment has been minimized.
According to the plan outlined [in Zulip](https://rust-lang.zulipchat.com/#narrow/channel/185405-t-compiler.2Frust-analyzer/topic/Breaking.20up.20hir-ty/near/617085080). This first step extracts the `hir-ide` crate, containing extra diagnostics, display, and tests. Tests must be in the leaf crate because they need access to the full database (some can go with a dummy impl for some methods, but it'll be more complicated than just moving them here). We had to make some compromises; pretty-printing MIR and MIR errors requires display, so we need it to be in `hir-ide`, but then it can't be an inherent method, so we made it an extension trait and also made a proc macro to make that easier (copied from rustc).
ChayimFriedman2
force-pushed
the
breakup-hir-ty-step1
branch
from
August 19, 2026 02:45
c9d552f to
10bf92f
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the plan outlined in Zulip.
This first step extracts the
hir-idecrate, containing extra diagnostics, display, and tests. Tests must be in the leaf crate because they need access to the full database (some can go with a dummy impl for some methods, but it'll be more complicated than just moving them here).We had to make some compromises; pretty-printing MIR and MIR errors requires display, so we need it to be in
hir-ide, but then it can't be an inherent method, so we made it an extension trait and also made a proc macro to make that easier (copied from rustc).hir_tywas find-and-replace'd withhir_ideincrates/hir/.