Improve diagnostic output of `non_local_definitions` lint - #125089

Merged

bors merged 11 commits into

rust-lang:masterfrom

Urgau:non_local_def-suggestions

May 28, 2024

Commits on May 27, 2024

non_local_defs: move out from `#[derive(LintDiagnostic)]` to manual impl
Urgau
committed
5ad4ad7
non_local_defs: switch to more friendly primary message
Urgau
committed
06c6a2d
non_local_defs: improve some notes around trait, bounds, consts
Urgau
committed
de1c122
non_local_defs: use span of the impl def and not the impl block
Urgau
committed
26b873d
non_local_defs: use labels to indicate what may need to be moved
Urgau
committed
22095fb
non_local_defs: improve exception note for impl and macro_rules!
Urgau
committed
402580b
non_local_defs: be more precise about what needs to be moved
Urgau
committed
d3dfe14
non_local_defs: improve main without a trait note
Urgau
committed
ab23fd8
non_local_defs: suggest removing leading ref/ptr to make the impl local
Urgau
committed
b719529
non_local_defs: point to Self and Trait to give more context
Urgau
committed
98273ec
non_local_defs: point the parent item when appropriate
Urgau
committed
c7d3004