Skip to content

Add desktop method to CommandExt - #158855

Open
Krakoer wants to merge 1 commit into
rust-lang:mainfrom
Krakoer:feat/commandext-desktop
Open

Add desktop method to CommandExt#158855
Krakoer wants to merge 1 commit into
rust-lang:mainfrom
Krakoer:feat/commandext-desktop

Conversation

@Krakoer

@Krakoer Krakoer commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown

This PR enables setting the lpDesktop field of the STARTUPINFO passed to the Windows CreateProcess API call by adding a desktop builder method to the Windows-specific CommandExt extension trait.

Accepted ACP: rust-lang/libs-team#221
Tracking issue: #158852

@rustbot rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 6, 2026
@rustbot

rustbot commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @jackh726 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 20 candidates

@rustbot

This comment has been minimized.

Sign in to view
@Krakoer
Krakoer force-pushed the feat/commandext-desktop branch from aa3867e to fc70bd5 Compare July 6, 2026 11:46
@Krakoer Krakoer mentioned this pull request Jul 6, 2026
Open
5 tasks
hkBst
hkBst suggested changes Jul 6, 2026
View reviewed changes
Comment thread library/std/src/sys/process/windows.rs Outdated
@Krakoer
Krakoer force-pushed the feat/commandext-desktop branch from fc70bd5 to 460704f Compare July 6, 2026 13:03
PaulDance
PaulDance reviewed Jul 6, 2026
View reviewed changes
Comment thread tests/ui/process/win-desktop.rs Outdated
Axel Rousselot
Add desktop method to CommandExt
d33b74b 
Adds the `desktop` method to the Windows `CommandExt` trait to enable
setting the `lpDesktop` field of the STARTUPINFO passed to the Windows
`CreateProcess` API call.
@Krakoer
Krakoer force-pushed the feat/commandext-desktop branch from 460704f to d33b74b Compare July 6, 2026 16:22
@Krakoer
Krakoer requested a review from hkBst July 23, 2026 14:21
@jackh726

jackh726 commented Aug 9, 2026

Copy link
Copy Markdown
Member

r? libs

@rustbot rustbot assigned Mark-Simulacrum and unassigned jackh726 Aug 9, 2026
@Mark-Simulacrum

Mark-Simulacrum commented Aug 9, 2026

Copy link
Copy Markdown
Member

r? ChrisDenton perhaps? I think this seems OK but have not reviewed the Windows API correctness closely or whether the UI test is reasonable.

@rustbot

rustbot commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

ChrisDenton is not on the review rotation at the moment.
They may take a while to respond.

@ChrisDenton

ChrisDenton commented Aug 19, 2026

Copy link
Copy Markdown
Member

Looks good to me, thanks! Sorry for the delay here.

I'm honestly not 100% sure the test will work in CI but I'm 90% sure so let's see how it goes...

@bors r+ rollup

@rust-bors

rust-bors Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d33b74b has been approved by ChrisDenton

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened.

Reason for tree closure: Main branch is broken

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 20, 2026
@JonathanBrouwer
Rollup merge of rust-lang#158855 - Krakoer:feat/commandext-desktop, r…
787b253 
…=ChrisDenton

Add `desktop` method to `CommandExt`

This PR enables setting the `lpDesktop` field of the STARTUPINFO passed to the Windows `CreateProcess` API call by adding a `desktop`  builder method to the [Windows-specific CommandExt extension trait](https://doc.rust-lang.org/stable/std/os/windows/process/trait.CommandExt.html).

Accepted ACP: rust-lang/libs-team#221
Tracking issue: rust-lang#158852
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 20, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 20, 2026
@JonathanBrouwer
Rollup merge of rust-lang#158855 - Krakoer:feat/commandext-desktop, r…
b3db0e3 
…=ChrisDenton

Add `desktop` method to `CommandExt`

This PR enables setting the `lpDesktop` field of the STARTUPINFO passed to the Windows `CreateProcess` API call by adding a `desktop`  builder method to the [Windows-specific CommandExt extension trait](https://doc.rust-lang.org/stable/std/os/windows/process/trait.CommandExt.html).

Accepted ACP: rust-lang/libs-team#221
Tracking issue: rust-lang#158852
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 20, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 20, 2026
@JonathanBrouwer
Rollup merge of rust-lang#158855 - Krakoer:feat/commandext-desktop, r…
3cde202 
…=ChrisDenton

Add `desktop` method to `CommandExt`

This PR enables setting the `lpDesktop` field of the STARTUPINFO passed to the Windows `CreateProcess` API call by adding a `desktop`  builder method to the [Windows-specific CommandExt extension trait](https://doc.rust-lang.org/stable/std/os/windows/process/trait.CommandExt.html).

Accepted ACP: rust-lang/libs-team#221
Tracking issue: rust-lang#158852
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 20, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 20, 2026
@JonathanBrouwer
Rollup merge of rust-lang#158855 - Krakoer:feat/commandext-desktop, r…
9298902 
…=ChrisDenton

Add `desktop` method to `CommandExt`

This PR enables setting the `lpDesktop` field of the STARTUPINFO passed to the Windows `CreateProcess` API call by adding a `desktop`  builder method to the [Windows-specific CommandExt extension trait](https://doc.rust-lang.org/stable/std/os/windows/process/trait.CommandExt.html).

Accepted ACP: rust-lang/libs-team#221
Tracking issue: rust-lang#158852
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 20, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Aug 20, 2026
@bors
Auto merge of #161425 - JonathanBrouwer:rollup-KKnteRO, r=JonathanBro…
ed96418 
…uwer

Rollup of 20 pull requests

Successful merges:

 - #152617 (std: implement `sleep_until` for Fuchsia)
 - #158934 (diagnostics: fix `let x: vec![]` suggestion pointing into stdlib)
 - #161277 (bootstrap: Move all non-module items out of the crate root)
 - #161295 (std: don't panic on long-elapsed deadlines for `sleep_until`)
 - #161368 (Double-word align `_Unwind_Exception`)
 - #161370 (Uplift rustfmt macro formatting fix)
 - #161378 (`FlowSensitiveAnalysis` cleanups)
 - #158032 (Offload expose device selection)
 - #158855 (Add `desktop` method to `CommandExt`)
 - #161199 (Add regression test for non lifetime binders)
 - #161302 (Add regression test for inconsistent import resolution from issue 147208)
 - #161329 (Add regression tests for a few fixed issues with E-needs-test)
 - #161330 (Add regression test for nested RPIT not an iterator ICE)
 - #161351 (Cleanup: Move impl of `#[rustc_dump_object_lifetime_defaults]`)
 - #161355 (Add file path to some archive build errors)
 - #161373 (Allow running EC2 jobs locally)
 - #161393 (Configure LLM policy URL for triagebot)
 - #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
 - #161410 (Fix rustdoc remapping `documentation` scope documentation)
 - #161415 (Update expect messages in path docs to better follow guidelines)
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 21, 2026
@jhpratt
Rollup merge of rust-lang#158855 - Krakoer:feat/commandext-desktop, r…
117977d 
…=ChrisDenton

Add `desktop` method to `CommandExt`

This PR enables setting the `lpDesktop` field of the STARTUPINFO passed to the Windows `CreateProcess` API call by adding a `desktop`  builder method to the [Windows-specific CommandExt extension trait](https://doc.rust-lang.org/stable/std/os/windows/process/trait.CommandExt.html).

Accepted ACP: rust-lang/libs-team#221
Tracking issue: rust-lang#158852
@jhpratt jhpratt mentioned this pull request Aug 21, 2026
Open
rust-bors Bot pushed a commit that referenced this pull request Aug 21, 2026
@bors
Auto merge of #161434 - jhpratt:rollup-hq3P7uc, r=jhpratt
d2cf40a 
Rollup of 25 pull requests

Successful merges:

 - #152617 (std: implement `sleep_until` for Fuchsia)
 - #158934 (diagnostics: fix `let x: vec![]` suggestion pointing into stdlib)
 - #160995 (Tiny readability cleanups for initialization dataflow analyses)
 - #161277 (bootstrap: Move all non-module items out of the crate root)
 - #161295 (std: don't panic on long-elapsed deadlines for `sleep_until`)
 - #161368 (Double-word align `_Unwind_Exception`)
 - #161370 (Uplift rustfmt macro formatting fix)
 - #161378 (`FlowSensitiveAnalysis` cleanups)
 - #161420 (Bump wasm-component-ld to 0.5.30)
 - #161429 (Tighten allocator `Send`/`Sync` requirements for `Arc` in preparation for refactor)
 - #158032 (Offload expose device selection)
 - #158855 (Add `desktop` method to `CommandExt`)
 - #160299 (Stabilize `bool::toggle`)
 - #160842 (Apply `&[T]` visualizer to `*const [T]`, `*mut [T]` and `Box<[T]>`)
 - #160981 (Partially support building and locating wasm proc-macros)
 - #161199 (Add regression test for non lifetime binders)
 - #161212 (rust-installer/install-template.sh: catch cp(1) error when installing…)
 - #161302 (Add regression test for inconsistent import resolution from issue 147208)
 - #161329 (Add regression tests for a few fixed issues with E-needs-test)
 - #161330 (Add regression test for nested RPIT not an iterator ICE)
 - #161331 (Bitset simplifications)
 - #161340 (rustdoc: enable scrolling only on table/code)
 - #161351 (Cleanup: Move impl of `#[rustc_dump_object_lifetime_defaults]`)
 - #161355 (Add file path to some archive build errors)
 - #161373 (Allow running EC2 jobs locally)
rust-bors Bot pushed a commit that referenced this pull request Aug 21, 2026
@bors
Auto merge of #161434 - jhpratt:rollup-hq3P7uc, r=jhpratt
16a623a 
Rollup of 25 pull requests

Successful merges:

 - #152617 (std: implement `sleep_until` for Fuchsia)
 - #158934 (diagnostics: fix `let x: vec![]` suggestion pointing into stdlib)
 - #160995 (Tiny readability cleanups for initialization dataflow analyses)
 - #161277 (bootstrap: Move all non-module items out of the crate root)
 - #161295 (std: don't panic on long-elapsed deadlines for `sleep_until`)
 - #161368 (Double-word align `_Unwind_Exception`)
 - #161370 (Uplift rustfmt macro formatting fix)
 - #161378 (`FlowSensitiveAnalysis` cleanups)
 - #161420 (Bump wasm-component-ld to 0.5.30)
 - #161429 (Tighten allocator `Send`/`Sync` requirements for `Arc` in preparation for refactor)
 - #158032 (Offload expose device selection)
 - #158855 (Add `desktop` method to `CommandExt`)
 - #160299 (Stabilize `bool::toggle`)
 - #160842 (Apply `&[T]` visualizer to `*const [T]`, `*mut [T]` and `Box<[T]>`)
 - #160981 (Partially support building and locating wasm proc-macros)
 - #161199 (Add regression test for non lifetime binders)
 - #161212 (rust-installer/install-template.sh: catch cp(1) error when installing…)
 - #161302 (Add regression test for inconsistent import resolution from issue 147208)
 - #161329 (Add regression tests for a few fixed issues with E-needs-test)
 - #161330 (Add regression test for nested RPIT not an iterator ICE)
 - #161331 (Bitset simplifications)
 - #161340 (rustdoc: enable scrolling only on table/code)
 - #161351 (Cleanup: Move impl of `#[rustc_dump_object_lifetime_defaults]`)
 - #161355 (Add file path to some archive build errors)
 - #161373 (Allow running EC2 jobs locally)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hkBst hkBst Awaiting requested review from hkBst
1 more reviewer
@PaulDance PaulDance PaulDance left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@ChrisDenton ChrisDenton

Labels

O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Krakoer @rustbot @jackh726 @Mark-Simulacrum @ChrisDenton @hkBst @PaulDance