-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
Add std::fs::{Home|Media}Dirs
#158936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CAD97
wants to merge
60
commits into
rust-lang:main
Choose a base branch
from
CAD97:dirs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add std::fs::{Home|Media}Dirs
#158936
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
fed84bc
Revert "Rollup merge of #157518 - CAD97:xdg_basedir, r=aapoalas"
CAD97 64b248e
add fs::UserDirs
CAD97 c64b404
add unix fs::UserDirsExt
CAD97 8a07e4b
add windows fs::UserDirsExt
CAD97 e7015a3
add darwin fs::UserDirsExt
CAD97 2200574
remove impl Default for UserDirs
CAD97 42aeaa5
add UserDirs::user_home
CAD97 6724135
order UserDirs fields more consistently
CAD97 b52be2b
minor fixes
CAD97 cf00aa5
use libc for darwin sysdir(3)
CAD97 5a41b4d
skip can_fetch_xdg_user_dirs test on darwin
CAD97 803bd46
minor fixes
CAD97 6e61768
minor fixes
CAD97 141d4ba
allow missing user-dirs.dirs for test
CAD97 957dd6b
fully cfg gate darwin UserDirsExt
CAD97 33696f9
add missing cast
CAD97 0f18752
fix doc links
CAD97 d93daba
fix broken doclinks
CAD97 fffff28
fix doclinks
CAD97 2a0c77e
make doc not look like broken doclink
CAD97 d19f2f8
refactor darwin UserDirsExt
CAD97 4bbd3c0
use objc names in darwin UserDirsExt docs
CAD97 778bf90
add more UserDirs docs
CAD97 6b6ed77
add user_home to UserDirs tests
CAD97 847bc3f
fix darwin sysdir iter
CAD97 3fc3c02
fix darwin UserDirsExt typo
CAD97 8dbd25d
split std:;fs::UserDirs
CAD97 d410551
fix darwin fs::dirs typo
CAD97 8663dfc
fix imports
CAD97 c8bdfc5
refactor xdg unquote
CAD97 e74f819
remove commented shlex dependency
CAD97 952e019
fix doclinks
CAD97 a0728c5
fix remaining UserDirs references
CAD97 e99806e
fix renames
CAD97 72e5972
fixes
CAD97 1f2cd59
fix
CAD97 030f02c
fix imports
CAD97 1b4a1e7
fix wasi pal
CAD97 fc34234
maybe fix import warning
CAD97 7840fba
unix doesnt mean cfg(unix)
CAD97 2cfedc2
wasi no fs?
CAD97 6de219b
used or unused make up your mind
CAD97 7e402f3
handle wasi right?
CAD97 bd5ad1a
clarify HomeDirs use case
CAD97 e220980
use impl(self) to seal UserDirsExt
CAD97 a540c49
Add windows HomeDirExt::appdir_env
CAD97 23bd91d
lazy-load shell32.dll
CAD97 423b884
comment why we lazy-load these DLLs
CAD97 594fa17
Avoid using futex on Win7
CAD97 a1ec10e
fix feature gating
CAD97 cc54b7c
fix can_fetch_known_folder_paths test
CAD97 2e5ed94
don't panic in shell32/ole32 fallbacks
CAD97 2007586
properly filter out relative paths in XDG MediaDirsExt
CAD97 7f5f839
improve user_dirs.dirs parsing
CAD97 095a693
require absolute %APPDATA% paths
CAD97 14cee7b
improve windows userdirs impl
CAD97 cbde092
fix win7 futex handling
CAD97 f956d96
unstable gate fix
CAD97 64fa9fd
windows fs::dirs fixes
CAD97 a11e762
yip yip
CAD97 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,313 @@ | ||
| use crate::env; | ||
| use crate::fs::{HomeDirs, MediaDirs}; | ||
| use crate::io::{self, ErrorKind, const_error}; | ||
| use crate::path::PathBuf; | ||
|
|
||
| /// Darwin-specific extensions to [`fs::HomeDirs`](HomeDirs). | ||
| #[unstable(feature = "dir_discovery", issue = "157515")] | ||
| pub impl(self) trait HomeDirsExt: Sized { | ||
| /// Load the standard user directory paths for the current user. | ||
| /// | ||
| /// On iOS, tvOS, watchOS, visionOS, and sandboxed macOS applications, | ||
| /// these directories are within the application's container. Outside | ||
| /// the sandbox, these are subdirectories of the `~/Library` directory on | ||
| /// macOS. | ||
| /// | ||
| /// The produced directory paths are not guaranteed to be the canonical | ||
| /// paths to the directories; they are allowed to be sandbox-redirected | ||
| /// paths as long as the directory is accessible there. | ||
| /// | ||
| /// The loaded common directories are: | ||
| /// | ||
| /// | `HomeDirs` | [`NSSearchPathDirectory`] | | ||
| /// | ---------- | ----------------------- | | ||
| /// | [`cache_home`] | [`NSCachesDirectory`] (`~/Library/Caches`) | | ||
| /// | [`config_home`] | [`NSApplicationSupportDirectory`] (`~/Library/Application Support`) | | ||
| /// | [`data_home`] | [`NSApplicationSupportDirectory`] (`~/Library/Application Support`) | | ||
| /// | [`state_home`] | [`NSApplicationSupportDirectory`] (`~/Library/Application Support`) | | ||
| /// | ||
| /// Note that the Application Support directory is used for the config, | ||
| /// data, and state directories. It is always possible for multiple user | ||
| /// directories to be configured to the same path, but this is the common | ||
| /// configuration on Apple platforms, making it even more important to not | ||
| /// assume files in different user directories cannot alias each other. | ||
| /// | ||
| /// # Errors | ||
| /// | ||
| /// Errors if the [user home](env::home_dir) cannot be determined. | ||
| // Errors due to the underlying sysdir(3) API should never occur, as | ||
| // - the user domain only has one directory for each search path; | ||
| // - the user domain always returns subdirectory paths of `~`; and | ||
| // - the username and OS defined path segments are always valid UTF-8. | ||
| /// | ||
| /// # Implementation-specific behavior | ||
| /// | ||
| /// Uses the `sysdir(3)` API from `libSystem` to discover the standard | ||
| /// user directories. | ||
| /// | ||
| /// This behavior may change in the future. One example change that we | ||
| /// explicitly reserve the right to make is to load additional common | ||
| /// directories not currently in this list. | ||
| /// | ||
| /// [`cache_home`]: HomeDirs::cache_home | ||
| /// [`config_home`]: HomeDirs::config_home | ||
| /// [`data_home`]: HomeDirs::data_home | ||
| /// [`state_home`]: HomeDirs::state_home | ||
| /// | ||
| /// [`NSSearchPathDirectory`]: https://developer.apple.com/documentation/foundation/filemanager/searchpathdirectory?language=objc | ||
| /// [`NSCachesDirectory`]: https://developer.apple.com/documentation/foundation/filemanager/searchpathdirectory/cachesdirectory?language=objc | ||
| /// [`NSApplicationSupportDirectory`]: https://developer.apple.com/documentation/foundation/filemanager/searchpathdirectory/applicationsupportdirectory?language=objc | ||
| #[unstable(feature = "dir_discovery", issue = "157515")] | ||
| fn sysdir() -> io::Result<Self>; | ||
| } | ||
|
|
||
| /// Darwin-specific extensions to [`fs::MediaDirs`](MediaDirs). | ||
| #[unstable(feature = "media_dir_discovery", issue = "157515")] | ||
| pub impl(self) trait MediaDirsExt: Sized { | ||
| /// Load the standard user directory paths for the current user. | ||
| /// | ||
| /// The produced directory paths are not guaranteed to be the canonical | ||
| /// paths to the directories; they are allowed to be sandbox-redirected | ||
| /// paths as long as the directory is accessible there. | ||
| /// | ||
| /// The loaded common directories are: | ||
| /// | ||
| /// | `MediaDirs` | [`NSSearchPathDirectory`] | | ||
| /// | ---------- | ----------------------- | | ||
| /// | [`desktop`] | [`NSDesktopDirectory`] (`~/Desktop`) | | ||
| /// | [`documents`] | [`NSDocumentDirectory`] (`~/Documents`) | | ||
| /// | [`downloads`] | [`NSDownloadsDirectory`] | | ||
| /// | [`music`] | [`NSMusicDirectory`] (`~/Music`) | | ||
| /// | [`pictures`] | [`NSPicturesDirectory`] (`~/Pictures`) | | ||
| /// | [`videos`] | [`NSMoviesDirectory`] (`~/Movies`) | | ||
| /// | ||
| /// # Errors | ||
| /// | ||
| /// Errors if the the [user home](env::home_dir) cannot be determined. | ||
| // Errors due to the underlying sysdir(3) API should never occur, as | ||
| // - the user domain only has one directory for each search path; | ||
| // - the user domain always returns subdirectory paths of `~`; | ||
| // - the username plus OS defined path segments cannot exceed PATH_MAX; and | ||
| // - the username and OS defined path segments are always valid UTF-8. | ||
| /// | ||
| /// # Implementation-specific behavior | ||
| /// | ||
| /// Uses the `sysdir(3)` API from `libSystem` to discover the standard | ||
| /// user directories. | ||
| /// | ||
| /// This behavior may change in the future. One example change that we | ||
| /// explicitly reserve the right to make is to load additional common | ||
| /// directories not currently in this list. | ||
| /// | ||
| /// [`desktop`]: MediaDirs::desktop | ||
| /// [`documents`]: MediaDirs::documents | ||
| /// [`downloads`]: MediaDirs::downloads | ||
| /// [`music`]: MediaDirs::music | ||
| /// [`pictures`]: MediaDirs::pictures | ||
| /// [`videos`]: MediaDirs::videos | ||
| /// | ||
| /// [`NSSearchPathDirectory`]: https://developer.apple.com/documentation/foundation/filemanager/searchpathdirectory?language=objc | ||
| /// [`NSDesktopDirectory`]: https://developer.apple.com/documentation/foundation/filemanager/searchpathdirectory/desktopdirectory?language=objc | ||
| /// [`NSDocumentDirectory`]: https://developer.apple.com/documentation/foundation/filemanager/searchpathdirectory/documentdirectory?language=objc | ||
| /// [`NSDownloadsDirectory`]: https://developer.apple.com/documentation/foundation/filemanager/searchpathdirectory/downloadsdirectory?language=objc | ||
| /// [`NSMusicDirectory`]: https://developer.apple.com/documentation/foundation/filemanager/searchpathdirectory/musicdirectory?language=objc | ||
| /// [`NSPicturesDirectory`]: https://developer.apple.com/documentation/foundation/filemanager/searchpathdirectory/picturesdirectory?language=objc | ||
| /// [`NSMoviesDirectory`]: https://developer.apple.com/documentation/foundation/filemanager/searchpathdirectory/moviesdirectory?language=objc | ||
| #[unstable(feature = "media_dir_discovery", issue = "157515")] | ||
| fn sysdir() -> io::Result<Self>; | ||
| } | ||
|
|
||
| fn user_home() -> io::Result<PathBuf> { | ||
| env::home_dir() | ||
| .filter(|p| p.is_absolute()) | ||
| .ok_or(const_error!(ErrorKind::InvalidData, "home path not absolute")) | ||
| } | ||
|
|
||
| #[unstable(feature = "dir_discovery", issue = "157515")] | ||
| #[cfg(target_vendor = "apple")] | ||
| impl HomeDirsExt for HomeDirs { | ||
| fn sysdir() -> io::Result<Self> { | ||
| use libc::sysdir_search_path_directory_t::*; | ||
|
|
||
| let mut dirs = HomeDirs::empty(); | ||
| let home = user_home()?; | ||
|
|
||
| let caches = sys::get_user_dir(&home, SYSDIR_DIRECTORY_CACHES)?; | ||
| let application_support = sys::get_user_dir(&home, SYSDIR_DIRECTORY_APPLICATION_SUPPORT)?; | ||
|
|
||
| dirs.cache = caches; | ||
| // Apple puts config/data/state all in Application Support | ||
| dirs.config = application_support.clone(); | ||
| dirs.data = application_support.clone(); | ||
| dirs.state = application_support; | ||
|
|
||
| Ok(dirs) | ||
| } | ||
| } | ||
|
|
||
| #[unstable(feature = "media_dir_discovery", issue = "157515")] | ||
| #[cfg(target_vendor = "apple")] | ||
| impl MediaDirsExt for MediaDirs { | ||
| fn sysdir() -> io::Result<Self> { | ||
| use libc::sysdir_search_path_directory_t::*; | ||
|
|
||
| let mut dirs = MediaDirs::empty(); | ||
| let home = user_home()?; | ||
|
|
||
| let desktop = sys::get_user_dir(&home, SYSDIR_DIRECTORY_DESKTOP)?; | ||
| let documents = sys::get_user_dir(&home, SYSDIR_DIRECTORY_DOCUMENT)?; | ||
| let downloads = sys::get_user_dir(&home, SYSDIR_DIRECTORY_DOWNLOADS)?; | ||
| let movies = sys::get_user_dir(&home, SYSDIR_DIRECTORY_MOVIES)?; | ||
| let music = sys::get_user_dir(&home, SYSDIR_DIRECTORY_MUSIC)?; | ||
| let pictures = sys::get_user_dir(&home, SYSDIR_DIRECTORY_PICTURES)?; | ||
|
|
||
| dirs.desktop = desktop; | ||
| dirs.documents = documents; | ||
| dirs.downloads = downloads; | ||
| dirs.music = music; | ||
| dirs.pictures = pictures; | ||
| dirs.videos = movies; | ||
|
|
||
| Ok(dirs) | ||
| } | ||
| } | ||
|
|
||
| /// Safer wrapper around the sysdir(3) API | ||
| #[cfg(target_vendor = "apple")] | ||
| mod sys { | ||
| use crate::ffi::{CStr, c_char}; | ||
| use crate::io::{self, ErrorKind, const_error}; | ||
| use crate::path::{Path, PathBuf}; | ||
|
|
||
| /// Get the path for a system directory using `sysdir(3)`. | ||
| pub fn get_user_dir( | ||
| home: &Path, | ||
| kind: libc::sysdir_search_path_directory_t, | ||
| ) -> io::Result<Option<PathBuf>> { | ||
| use libc::sysdir_search_path_domain_mask_t::SYSDIR_DOMAIN_MASK_USER; | ||
|
|
||
| // SAFETY: SYSDIR_DOMAIN_MASK_USER < SYSDIR_DOMAIN_MASK_ALL | ||
| let mut iter = unsafe { Iter::new(home, kind, SYSDIR_DOMAIN_MASK_USER) }; | ||
| let Some(path) = iter.next() else { | ||
| return Ok(None); | ||
| }; | ||
| let path = path?; | ||
|
|
||
| if iter.next().is_some() { | ||
| // more than one path returned (shouldn't happen for SYSDIR_DOMAIN_MASK_USER) | ||
| return Err(const_error!( | ||
| ErrorKind::InvalidData, | ||
| "multiple paths returned for standard user directory", | ||
| )); | ||
| } | ||
|
|
||
| Ok(Some(path)) | ||
| } | ||
|
|
||
| struct Iter<'a> { | ||
| home: &'a Path, | ||
| state: libc::sysdir_search_path_enumeration_state, | ||
| } | ||
|
|
||
| impl Drop for Iter<'_> { | ||
| fn drop(&mut self) { | ||
| for _ in self {} | ||
| } | ||
| } | ||
|
|
||
| impl<'a> Iter<'a> { | ||
| // SAFETY: `mask` must be <= `SYSDIR_DOMAIN_MASK_ALL` | ||
| pub unsafe fn new( | ||
| home: &'a Path, | ||
| kind: libc::sysdir_search_path_directory_t, | ||
| mask: libc::sysdir_search_path_domain_mask_t, | ||
| ) -> Self { | ||
| // SAFETY: forwarded to the caller | ||
| let state = unsafe { libc::sysdir_start_search_path_enumeration(kind, mask) }; | ||
| Self { home, state } | ||
| } | ||
| } | ||
|
|
||
| impl Iterator for Iter<'_> { | ||
| type Item = io::Result<PathBuf>; | ||
|
|
||
| fn next(&mut self) -> Option<io::Result<PathBuf>> { | ||
| let mut buf = [0u8; libc::PATH_MAX as usize]; | ||
| if self.state != 0 { | ||
| // SAFETY: `self.state` is nonzero and comes from prior sysdir_{start|get_next}_search_path_enumeration call | ||
| // SAFETY: sysdir_get_next_search_path_enumeration will write at most `PATH_MAX` bytes to `path` | ||
| self.state = unsafe { | ||
| libc::sysdir_get_next_search_path_enumeration( | ||
| self.state, | ||
| buf.as_mut_ptr() as *mut c_char, | ||
| ) | ||
| }; | ||
| } | ||
|
|
||
| if self.state == 0 { | ||
| // exhausted | ||
| return None; | ||
| } | ||
|
|
||
| let Ok(path) = CStr::from_bytes_until_nul(&buf) else { | ||
| // should be impossible given home-relative paths, but be defensive | ||
| return Some(Err(const_error!( | ||
| ErrorKind::InvalidData, | ||
| "standard user directory path too long", | ||
| ))); | ||
| }; | ||
|
|
||
| let Ok(path) = path.to_str() else { | ||
| // should be impossible on a working system, but be defensive | ||
| return Some(Err(const_error!( | ||
| ErrorKind::InvalidData, | ||
| "standard user directory path not valid UTF-8", | ||
| ))); | ||
| }; | ||
|
|
||
| // expand `~` shorthand | ||
| Some(match path { | ||
| "~" => Ok(self.home.into()), | ||
| _ if path.starts_with("~/") => Ok(self.home.join(&path[2..])), | ||
| _ if path.starts_with("~") => Err(const_error!( | ||
| ErrorKind::InvalidData, | ||
| "standard user directory relative to different user", | ||
| )), | ||
| _ => { | ||
| let path = PathBuf::from(path); | ||
| if path.is_relative() { | ||
| Err(const_error!( | ||
| ErrorKind::InvalidData, | ||
| "standard user directory path not absolute", | ||
| )) | ||
| } else { | ||
| Ok(path) | ||
| } | ||
| } | ||
| }) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| #[cfg(test)] | ||
| #[cfg(target_vendor = "apple")] | ||
| mod tests { | ||
| use super::*; | ||
|
|
||
| #[test] | ||
| fn can_fetch_sysdir_paths() { | ||
| let dirs = HomeDirs::sysdir().unwrap(); | ||
| assert!(dirs.cache_home().is_some()); | ||
| assert!(dirs.config_home().is_some()); | ||
| assert!(dirs.data_home().is_some()); | ||
| assert!(dirs.state_home().is_some()); | ||
|
|
||
| let dirs = MediaDirs::sysdir().unwrap(); | ||
| assert!(dirs.desktop().is_some()); | ||
| assert!(dirs.documents().is_some()); | ||
| assert!(dirs.downloads().is_some()); | ||
| assert!(dirs.music().is_some()); | ||
| assert!(dirs.pictures().is_some()); | ||
| assert!(dirs.videos().is_some()); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, why?
View changes since the review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming, tbqh; the manpage doesn't really specify. Note that here libc incorrectly translates
sysdir_search_path_domain_mask_tas an enum when it's a bitmask, so there's no potential for unsafety currently, but I'm being conservative.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did see that libc issue, yeah.
I'm confident that it's not an issue though, the only way I could imagine it would work differently is if they decided in the future to use the rest of the integer for flags, and one of those flags doing something unsound. But that sounds improbable given that we're using the API in exactly the intended / documented fashion.
(It sounds a lot more likely to me that they'd add a new API if they really needed some new functionality).