Upgrade and deduplicate dependencies - #160529
Open
cuviper wants to merge 2 commits into
Open
Conversation
Collaborator
|
The run-make-support library was changed cc @jieyouxu The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. cc @davidtwco, @BoxyUwU
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
rustbot
added
A-LLVM
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Mark-Simulacrum
approved these changes
Aug 8, 2026
| // which the loader uses to find the library. | ||
| stub.write_align_dynamic(); | ||
| stub.write_dynamic_string(elf::DT_SONAME, soname); | ||
| stub.write_dynamic_string(elf::DT_SONAME, soname).unwrap(); |
Member
There was a problem hiding this comment.
I think the failures here are:
Returns an error for 32-bit ELF overflows.
(https://docs.rs/object/latest/object/write/elf/struct.Encoder.html#method.dynamic)
Not sure if those can happen for user reasons, but I guess either way this is just an ICE so seems OK.
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 9, 2026
Upgrade and deduplicate dependencies - Upgrade from `getrandom v0.4.2` to `v0.4.3` to drop its `wasip2` and `wasip3` dependencies and many transitives. - Upgrade from `gimli v0.33` to `v0.34` as a direct dependency and through a `thorin-dwp` upgrade. - Upgrade from `object v0.37` and `v0.38` to `v0.39` as a direct dependency and via `ar_archive_writer` and `thorin-dwp` upgrades. - Upgrade `libloading` and `wasmparser` to match other dependencies. This also consolidates from `hashbrown v0.15`, `v0.16`, and `v0.17` to just `v0.17.1`, which is the same that `std` currently uses.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 9, 2026
Rollup of 6 pull requests Successful merges: - #160529 (Upgrade and deduplicate dependencies) - #158517 (Initial implementation of named `Fn` trait parameters) - #158587 (check if len of array const arg matches the expected len of the type when lowering to valtree) - #160748 (Add regression test for cross-crate assoc const private field leak in rustdoc) - #160708 (remove old update mechanism) - #160768 (Fix autodiff_illegal.rs test)
Member
|
As the only PR in #160786 that touches wasm in any manner, I believe this is the cause of the rollup failure. Running a try build for certainty. @bors try jobs=test-various |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. This PR was contained in a rollup (#160786), which was unapproved. |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 9, 2026
Upgrade and deduplicate dependencies try-job: test-various
Contributor
|
💔 Test for 38e3081 failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
- Upgrade from `getrandom v0.4.2` to `v0.4.3` to drop its `wasip2` and `wasip3` dependencies and many transitives. - Upgrade from `gimli v0.33` to `v0.34` as a direct dependency and through a `thorin-dwp` upgrade. - Upgrade from `object v0.37` and `v0.38` to `v0.39` as a direct dependency and via `ar_archive_writer` and `thorin-dwp` upgrades. - Upgrade `libloading` and `wasmparser` to match other dependencies. This also consolidates from `hashbrown v0.15`, `v0.16`, and `v0.17` to just `v0.17.1`, which is the same that `std` currently uses.
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
@bors try jobs=test-various |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 9, 2026
Upgrade and deduplicate dependencies try-job: test-various
Contributor
Contributor
|
☔ The latest upstream changes (presumably #160830) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getrandom v0.4.2tov0.4.3to drop itswasip2andwasip3dependencies and many transitives.gimli v0.33tov0.34as a direct dependency andthrough a
thorin-dwpupgrade.object v0.37andv0.38tov0.39as a directdependency and via
ar_archive_writerandthorin-dwpupgrades.libloadingandwasmparserto match other dependencies.This also consolidates from
hashbrown v0.15,v0.16, andv0.17tojust
v0.17.1, which is the same thatstdcurrently uses.