Enable -Znext-solver on nightly by default - #160619
Conversation
This comment has been minimized.
This comment has been minimized.
58af33d to
0460872
Compare
This comment has been minimized.
This comment has been minimized.
0460872 to
0ea6562
Compare
This comment has been minimized.
This comment has been minimized.
0ea6562 to
5742bfa
Compare
This comment has been minimized.
This comment has been minimized.
5742bfa to
71b11fe
Compare
This comment has been minimized.
This comment has been minimized.
d68c99e to
957226b
Compare
This comment has been minimized.
This comment has been minimized.
957226b to
db02309
Compare
This comment has been minimized.
This comment has been minimized.
db02309 to
d5d6c07
Compare
This comment has been minimized.
This comment has been minimized.
d5d6c07 to
1acf8a5
Compare
|
Note that #161273 is also approved, and it also enables a new unstable feature on nightly by default. While it should be much less invasive as the next trait solver, it can in theory also cause some breakages. I think that we shouldn't land both in the same nightly. I'm fine with giving this PR more priority if you want, though we already put out a blog post about the Cargo change (https://blog.rust-lang.org/inside-rust/2026/08/18/reducing-target-dir-size-on-nightly/). |
|
ehh |
|
@bors r- |
|
This pull request was unapproved. |
as in, merge next-solver tomorrow instead? Seems fine to me. One day more or less doesn't matter much and means we don't have to rush as much here |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Yup. Btw the PR CI failure looks real. |
|
Finished benchmarking commit (f8af1d1): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never rustc-perf Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 3.4%, secondary 4.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 6.3%, secondary 5.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 455.347s -> 467.92s (2.76%) |
|
The perf. result should be neutral, so something is wrong somewhere. |
|
Note that rustc-perf only passes This is a Cachegrind diff for the diesel/check benchmark: |
Update the `rustc-perf` submodule To bring in rust-lang/rustc-perf#2537, so that we unblock rust-lang#160619. r? lcnr
Update the `rustc-perf` submodule To bring in rust-lang/rustc-perf#2537, so that we unblock rust-lang#160619. r? lcnr
Update the `rustc-perf` submodule To bring in rust-lang/rustc-perf#2537, so that we unblock rust-lang#160619. r? lcnr
|
blocked on #161344 |
Update the `rustc-perf` submodule To bring in rust-lang/rustc-perf#2537, so that we unblock rust-lang#160619. r? lcnr
Update the `rustc-perf` submodule To bring in rust-lang/rustc-perf#2537, so that we unblock rust-lang#160619. r? lcnr
Update the `rustc-perf` submodule To bring in rust-lang/rustc-perf#2537, so that we unblock rust-lang#160619. r? lcnr
Rollup merge of #161344 - Kobzol:update-rustc-perf, r=lqd Update the `rustc-perf` submodule To bring in rust-lang/rustc-perf#2537, so that we unblock #160619. r? lcnr
View all comments
Implementation of rust-lang/compiler-team#1014 cc rust-lang/blog.rust-lang.org#1896 #160895
This enables
-Znext-solver=globallyby default in nightly, but keeps-Znext-solver=coherencefor tests