Skip to content

Get rid of LLM disclosure checkboxes #160785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jyn514 wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −8
Open

Get rid of LLM disclosure checkboxes #160785

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbad7aa
Get rid of LLM disclosure checkboxes
jyn514 Aug 9, 2026
91f0930
generalize from 'code' to 'any part of this PR'
jyn514 Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
<!-- homu-ignore:start -->

- [ ] I did not use an LLM to create a change in this PR.
- [ ] I used an LLM to create a change in this PR, and I have explained below how it was used.

<!--
Please read our [LLM policy] before opening a PR,
and check one of the boxes above to indicate whether you've used an LLM.
If you do not check a box, a reviewer may ask you whether an LLM was involved.
If you used an LLM to generate any part of this PR, including the PR description, please disclose that according to our [guidelines][disclosure guidelines].
LLM contributions are not banned, but are held to a higher standard of review and correctness.
If you do not want your disclosure to be part of the permanent git history, add `<!-- homu-ignore:start` before it.

@asquared31415 asquared31415 Aug 9, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the tooling smart enough to not parse the homu-ignore when it's within a comment?

View changes since the review

@teor2345 teor2345 Aug 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for that reason.
This one will be ignored because there's no matching end:
https://github.com/rust-lang/bors/blob/a4b1de2d268c4b54c0830efa4f315b14e6a2335f/src/bors/mod.rs#L341

@asquared31415 asquared31415 Aug 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably important to fix then, either in bors or in the template. I could see this interacting poorly with other ignore comments. I believe that if you had a situation of:

  • start (from this template)
  • real content
  • start (manual)
  • ignored content
  • end

then all of the real content would be ignored.

@teor2345 teor2345 Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could fix the implementation to ignore escaped comment blocks, but that seems like it might complicate the bors code a bit.

Or we could change the PR template to link to documentation for the ignore block?

@joshtriplett joshtriplett Aug 9, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we just drop this line instead, please? The disclosure is useful information.

View changes since the review

@jyn514 jyn514 Aug 9, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

people should have control over what they put in a permanent record.

@RalfJung RalfJung Aug 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think requiring the disclosure to be in the permanent record is useful.

@jyn514 jyn514 Aug 9, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust-forge/pull/1040#discussion_r3382826548

@RalfJung RalfJung Aug 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think github has any kind of moderation controls on commits themselves, even though it lets people comment.

We can disable comments on commits entirely:
https://github.blog/changelog/2026-03-25-disable-comments-on-individual-commits/

I think this s useful technical information that's worth preserving. But 🤷 I also won't spend a lot of effort arguing about this now so fine to let it go.


[LLM policy]: https://forge.rust-lang.org/policies/llm-usage.html
[disclosure guidelines]: https://rustc-dev-guide.rust-lang.org/llm-guidance/writing.html#disclosure-guidelines

If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
Expand All @@ -20,4 +16,3 @@ a specific user to review your work, you can assign it to them by using

r? <reviewer name>
-->
<!-- homu-ignore:end -->
Loading